-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Private sites] Copy updates #40962
[Private sites] Copy updates #40962
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~542 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise, LGTM.
43fa427
to
7c8b957
Compare
Test failures look unrelated - merging |
Changes proposed in this Pull Request
This PR improves the copy related to private sites.
Test instructions and details:
Settings page
With this PR, it should provide an intuitive copy that distinct between the private and coming soon modes.
SEO settings page
Before this PR, it always displays the Coming Soon copy, even if the site is just private:
With this PR it displays appropriate copy: