Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Private sites] Copy updates #40962

Merged
merged 7 commits into from
Apr 10, 2020
Merged

Conversation

adamziel
Copy link
Contributor

@adamziel adamziel commented Apr 9, 2020

Changes proposed in this Pull Request

This PR improves the copy related to private sites.

Test instructions and details:

Settings page

With this PR, it should provide an intuitive copy that distinct between the private and coming soon modes.

Zrzut ekranu 2020-04-9 o 16 04 01

SEO settings page

Before this PR, it always displays the Coming Soon copy, even if the site is just private:

Zrzut ekranu 2020-04-9 o 15 00 16

With this PR it displays appropriate copy:

Zrzut ekranu 2020-04-9 o 15 00 54

@adamziel adamziel self-assigned this Apr 9, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented Apr 9, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~542 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
settings                  +1528 B  (+0.4%)     +330 B  (+0.3%)
themes                     +469 B  (+0.1%)      +53 B  (+0.1%)
settings-performance       +469 B  (+0.2%)      +53 B  (+0.1%)
plugins                    +469 B  (+0.1%)      +53 B  (+0.1%)
hosting                    +469 B  (+0.3%)      +53 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@adamziel adamziel added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Private by Default labels Apr 9, 2020
Copy link
Member

@michaeldcain michaeldcain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise, LGTM.

@adamziel adamziel force-pushed the update/private-sites-copy-updates branch from 43fa427 to 7c8b957 Compare April 10, 2020 09:04
@adamziel
Copy link
Contributor Author

Test failures look unrelated - merging

@adamziel adamziel merged commit 64e85df into master Apr 10, 2020
@adamziel adamziel deleted the update/private-sites-copy-updates branch April 10, 2020 10:11
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants