-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack Cloud: Fix failed backup state design #41689
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~20 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bb7e0b1
to
3fe789a
Compare
Remove the "View to get the issue resolved" copy that doesn't match with the design
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it looks good. I removed the weird copy that doesn't match with the expected in the design.
LGTM!
Changes proposed in this Pull Request
DailyBackupStatus
so that it more closely matches the FigmasTesting instructions
renderBackupStatus()
. Check to be sure that the design closely matches the Figma, and the new (proper) icon is present.Fixes 1142395350490785-as-1173118334902057