Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Cloud: Fix failed backup state design #41689

Merged
merged 3 commits into from
May 7, 2020

Conversation

rcoll
Copy link
Member

@rcoll rcoll commented Apr 30, 2020

Changes proposed in this Pull Request

  • Fix the backup failed state in DailyBackupStatus so that it more closely matches the Figmas

Testing instructions

  • Check daily backup status for a date that has a failed backup. Force one manually if needed in renderBackupStatus(). Check to be sure that the design closely matches the Figma, and the new (proper) icon is present.

Fixes 1142395350490785-as-1173118334902057

@rcoll rcoll added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) labels Apr 30, 2020
@rcoll rcoll requested a review from a team April 30, 2020 19:05
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented Apr 30, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~20 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
backups        +66 B  (+0.0%)      +20 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@cleacos cleacos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the mobile version, the size of the icon seems not to match the design, and the position of the 'Backup failed' copy :
image

From the design:
image

@rcoll rcoll force-pushed the fix/jetpack-cloud-backup-fail-style branch from bb7e0b1 to 3fe789a Compare May 6, 2020 15:24
Richard Collier and others added 3 commits May 6, 2020 11:25
Remove the "View to get the issue resolved" copy that doesn't match with the design
Copy link
Contributor

@cleacos cleacos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it looks good. I removed the weird copy that doesn't match with the expected in the design.

LGTM!

@rcoll rcoll merged commit 79ea6ee into master May 7, 2020
@rcoll rcoll deleted the fix/jetpack-cloud-backup-fail-style branch May 7, 2020 20:02
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants