-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domains: Add Luhn check for SIREN/SIRET values #41816
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~252 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works as expected 🎉
However, lonng-term we'll have to do this check on the backend instead, because that's what the new checkout uses. But in the meantime I'll be happy to get rid of the registration failures caused by invalid SIREN/SIRET numbers...
@@ -25,7 +25,7 @@ describe( 'validateContactDetails', () => { | |||
extra: { | |||
fr: { | |||
registrantType: 'individual', | |||
sirenSiret: '123456789', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hahaha, love that the old test used an invalid SIREN number and still passed :D
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3502280 Thank you @eltongo for including a screenshot in the description! This is really helpful for our translators. |
Changes proposed in this Pull Request
This PR updates validation checks for .fr domains, to include a Luhn check on the SIREN/SIRET value provided by the user.
Testing instructions
yarn run test-client "client/components/domains/registrant-extra-info/test"
)This error should appear when the value is not valid (i.e. invalid characters or length):
This error should appear when everything else is OK, but the Luhn check fails: