Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenboarding: Integrate PlansTable & PlansDetails into PlansGrid. #41935

Merged
merged 8 commits into from
May 8, 2020
Merged

Gutenboarding: Integrate PlansTable & PlansDetails into PlansGrid. #41935

merged 8 commits into from
May 8, 2020

Conversation

yansern
Copy link
Contributor

@yansern yansern commented May 7, 2020 •
edited by razvanpapadopol
Loading

Changes proposed in this Pull Request

  • move onboarding-block/plans into components/plans/plans-table & components/plans/plans-details.
  • insert plans-table & plans-details into plans-grid.
  • remove title & subtitle from the mockup
  • wire-up plan selection logic

Testing instructions

Note: works behind feature-flag atm.

  • Go to /new?flags=gutenboarding/plans-grid
  • Press the Plan button (top-right) which should have the value Free Plan with an empty state.
  • Select another plan and click Confirm button.
  • The Plan button should now display the new selected plan.
  • When returning later to Gutenboarding the selected (and confirmed) plan label should be still displayed in the Plan button and pre-selected when opening the Plans grid.
  • After completing Gutenboarding with site creation, selected plan should be reset.

Screenshot

image

Fixes part of #41787

@yansern yansern added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Goal] New Onboarding previously called Gutenboarding labels May 7, 2020
@yansern yansern requested review from razvanpapadopol and a team May 7, 2020 12:57
@yansern yansern self-assigned this May 7, 2020
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/gutenboarding-plans-grid-mockup-integration

@yansern yansern changed the title Update/gutenboarding plans grid mockup integration Gutenboarding: Integrate PlansTable & PlansDetails into PlansGrid. May 7, 2020
@matticbot
Copy link
Contributor

matticbot commented May 7, 2020 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~304 bytes added 📈 [gzipped])

name                 parsed_size           gzip_size
entry-gutenboarding       +906 B  (+0.1%)     +304 B  (+0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@alshakero alshakero force-pushed the update/gutenboarding-plans-grid-mockup-integration branch from 158094d to 0060ace Compare May 7, 2020 16:04
@razvanpapadopol razvanpapadopol force-pushed the update/gutenboarding-plans-grid-mockup-integration branch from c5451ab to 8807a5a Compare May 8, 2020 08:49
@razvanpapadopol razvanpapadopol requested a review from a team May 8, 2020 08:50
alshakero
alshakero approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@alshakero alshakero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it a couple times (while I worked on it) and it works.

@yansern yansern merged commit 1b7437d into master May 8, 2020
@yansern yansern deleted the update/gutenboarding-plans-grid-mockup-integration branch May 8, 2020 09:24
@razvanpapadopol razvanpapadopol removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvanpapadopol razvanpapadopol razvanpapadopol left review comments

@alshakero alshakero alshakero approved these changes

@simison simison Awaiting requested review from simison

Assignees

@yansern yansern

Labels
[Goal] New Onboarding previously called Gutenboarding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yansern @matticbot @simison @razvanpapadopol @alshakero