Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack: Improve styles on WPCOMScanUpsell +added WhatIsJetpack #43292

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

cleacos
Copy link
Contributor

@cleacos cleacos commented Jun 15, 2020

Changes proposed in this Pull Request

Improve some styles on WPCOMScanUpsell component and add to the bottom WhatIsJetpack component.

Before:
image

After:
image

Testing instructions

  • Apply these changes and active Jetpack section with ?flags=jetpack/features-section
  • Select AT site without Jetpack
  • Go to Scan section and see the new What is Jetpack block and the styles applied like the screenshot

@cleacos cleacos added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) labels Jun 15, 2020
@cleacos cleacos requested a review from a team June 15, 2020 13:54
@cleacos cleacos self-assigned this Jun 15, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~228 bytes added 📈 [gzipped])

name  parsed_size           gzip_size
scan       +936 B  (+0.3%)     +228 B  (+0.3%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@ChaosExAnima ChaosExAnima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cleacos cleacos merged commit d050181 into master Jun 15, 2020
@cleacos cleacos deleted the update/jetpack-scan-wpcom-upsell branch June 15, 2020 15:36
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 15, 2020
@a8ci18n
Copy link

a8ci18n commented Jun 15, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3849798

Thank you @cleacos for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Aug 4, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants