Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains: Move GSuite TOS notice to domain card #43455

Merged
merged 5 commits into from
Jun 22, 2020

Conversation

eltongo
Copy link
Contributor

@eltongo eltongo commented Jun 18, 2020

Changes proposed in this Pull Request

This moves the GSuite TOS notice to the domain card to have a similar look and feel to the rest of domain notices.

Single email address:
Screenshot 2020-06-18 at 8 28 57 PM

Multiple email addresses:
Screenshot 2020-06-18 at 8 22 22 PM

Testing instructions

  • Purchase G Suite for a mapped or registered domain of yours
  • Verify that one of the messages from the screenshots above is shown according to the number of email addresses
  • Make sure the 'Get started' button works as expected

@eltongo eltongo added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature Group] Emails & Domains Features related to email integrations and domain management. G Suite labels Jun 18, 2020
@eltongo eltongo requested review from fditrapani and a team June 18, 2020 18:50
@eltongo eltongo self-assigned this Jun 18, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented Jun 18, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~868 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
domains      +1896 B  (+0.2%)     +376 B  (+0.2%)
plans         +979 B  (+0.2%)     +246 B  (+0.2%)
email         +979 B  (+0.3%)     +246 B  (+0.3%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~246 bytes added 📈 [gzipped])

name                                              parsed_size           gzip_size
async-load-my-sites-current-site-domain-warnings       +979 B  (+1.7%)     +246 B  (+1.6%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@fditrapani fditrapani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works great! Thank you.

@stephanethomas
Copy link
Contributor

I gave it a try, and it worked fine. I just wanted to mention that these notices have a different severity (red versus orange) and copy (urgent versus average priority) everywhere else:

Urgent! To activate your email email@example.com, click "Finish Setup".

Do we have plans to make all those notices more consistent?

@stephanethomas stephanethomas added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jun 22, 2020
@fditrapani
Copy link
Contributor

Do we have plans to make all those notices more consistent?

Thanks for bringing this up @stephanethomas. We do have plans to update this, and make it consistent, in the new domain manager. If you come across any other instances do you mind letting one of us know or adding an issue to Asana?

@eltongo eltongo merged commit 6ffe00f into master Jun 22, 2020
@eltongo eltongo deleted the update/email-config-status branch June 22, 2020 18:22
@a8ci18n
Copy link

a8ci18n commented Jun 22, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3914103

Thank you @eltongo for including a screenshot in the description! This is really helpful for our translators.

@stephanethomas
Copy link
Contributor

We do have plans to update this, and make it consistent, in the new domain manager. If you come across any other instances do you mind letting one of us know or adding an issue to Asana?

Excellent. We display those 'Finish Setup' notices in the sidebar as well as on the My Plan, Domains and Email pages. PaZD23-kS-p2 has screenshots for each of them.

@fditrapani
Copy link
Contributor

fditrapani commented Jun 24, 2020

Thanks Stéphane! I took another look through these and considering some other updates that are coming down the pipe with notifications, I wonder if we'd be better off not touching them for now. I'll create an issue to update the colours and copy on the domain screen to match everything else to minimize the update and perhaps revisit this messaging as a whole down the line.

@a8ci18n
Copy link

a8ci18n commented Jul 3, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3914103

Thank you @eltongo for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Jul 24, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management. G Suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants