-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domains: Move GSuite TOS notice to domain card #43455
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~868 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~246 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it works great! Thank you.
client/my-sites/domains/components/domain-warnings/pending-gsuite-tos-notice-action.js
Outdated
Show resolved
Hide resolved
client/my-sites/domains/domain-management/edit/domain-types/mapped-domain-type.jsx
Show resolved
Hide resolved
I gave it a try, and it worked fine. I just wanted to mention that these notices have a different severity (red versus orange) and copy (urgent versus average priority) everywhere else:
Do we have plans to make all those notices more consistent? |
Thanks for bringing this up @stephanethomas. We do have plans to update this, and make it consistent, in the new domain manager. If you come across any other instances do you mind letting one of us know or adding an issue to Asana? |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3914103 Thank you @eltongo for including a screenshot in the description! This is really helpful for our translators. |
Excellent. We display those 'Finish Setup' notices in the sidebar as well as on the |
Thanks Stéphane! I took another look through these and considering some other updates that are coming down the pipe with notifications, I wonder if we'd be better off not touching them for now. I'll create an issue to update the colours and copy on the domain screen to match everything else to minimize the update and perhaps revisit this messaging as a whole down the line. |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3914103 Thank you @eltongo for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
This moves the GSuite TOS notice to the domain card to have a similar look and feel to the rest of domain notices.
Single email address:
Multiple email addresses:
Testing instructions