Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jetpack Settings Host Detection #45371

Merged
merged 11 commits into from
Sep 7, 2020
Merged

Conversation

cbauerman
Copy link
Contributor

@cbauerman cbauerman commented Sep 2, 2020

Changes proposed in this Pull Request

Motivation: Add the host detection step from the SSH credentials host specific instructions project ( p1HpG7-9Nd-p2 ).

  • Add the host detection/guess/selection step from the project
  • Support new WPCOM Host Guess API
  • Add new routes for host detection and credentials step in the Jetpack Cloud settings module
  • Rejigger file structure in the Jetpack Cloud settings module
  • Minor update to StepProgress Component to accept translation results as well as strings

Untitled 9@0 5x

Testing instructions

  1. boot branch w/ env ENABLE_FEATURES=jetpack/server-credentials-advanced-flow yarn run start-jetpack-cloud
  2. Navigate to "Settings" for a site.
  3. Verify your screen matches "Host Selection w/out guess" above"
  4. Chose a host, verify it now match "Credentials Placeholder"
  5. Apply 49131-code & sandbox public-api.wordpress.com
  6. redo steps 2-4, this time expecting "Host Selection w/ guess" if your host matches one on the list

@cbauerman cbauerman added [Status] In Progress Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) labels Sep 2, 2020
@cbauerman cbauerman self-assigned this Sep 2, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented Sep 2, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~4973 bytes added 📈 [gzipped])

name                    parsed_size            gzip_size
jetpack-cloud-settings     +17010 B  (+12.2%)    +4379 B  (+11.0%)
settings                     +380 B   (+0.1%)      +84 B   (+0.1%)
backup                       +380 B   (+0.1%)      +81 B   (+0.1%)
activity                     +380 B   (+0.1%)      +80 B   (+0.1%)
woocommerce                  +245 B   (+0.0%)      +47 B   (+0.0%)
signup                       +245 B   (+0.1%)      +51 B   (+0.1%)
reader                       +245 B   (+0.0%)      +57 B   (+0.0%)
people                       +245 B   (+0.1%)      +49 B   (+0.0%)
account                      +245 B   (+0.1%)      +49 B   (+0.0%)
stats                        +135 B   (+0.0%)      +40 B   (+0.0%)
plans                        +135 B   (+0.0%)      +56 B   (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~291 bytes added 📈 [gzipped])

name                                   parsed_size           gzip_size
async-load-design-playground                +409 B  (+0.0%)      +63 B  (+0.0%)
async-load-design                           +409 B  (+0.0%)      +57 B  (+0.0%)
async-load-design-blocks                    +245 B  (+0.0%)      +39 B  (+0.0%)
async-load-signup-steps-clone-point         +135 B  (+0.1%)      +45 B  (+0.1%)
async-load-my-sites-sidebar                 +135 B  (+0.1%)      +44 B  (+0.1%)
async-load-components-jetpack-sidebar       +135 B  (+0.4%)      +43 B  (+0.4%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@cbauerman cbauerman requested a review from a team September 4, 2020 18:02
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 4, 2020
@cbauerman cbauerman marked this pull request as ready for review September 4, 2020 18:02
@cbauerman cbauerman merged commit aae1bb2 into master Sep 7, 2020
@cbauerman cbauerman deleted the add/jetpack-cloud-host-detection branch September 7, 2020 21:01
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 7, 2020
@a8ci18n
Copy link

a8ci18n commented Sep 7, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/4347718

Thank you @cbauerman for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Nov 13, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants