Coming soon: Send `public_coming_soon` site creation flag in development builds #45428

p-jackson · 2020-09-07T06:35:55Z

Changes proposed in this Pull Request

Opt-in to coming soon v2 behaviour if ?public-coming-soon is present and on wpcalypso.wordpress.com or a development build
Send public_coming_soon flag to /sites/new endpoint
Disable private-by-default behaviour
Set new coming-soon sites as non-indexable

The public_coming_soon API option was merged in D49202-code, and it just sets the wpcom_public_coming_soon site option.

Part of #45019

Testing instructions

Create a new site with localhost:3000/new?flags=gutenboarding/public-coming-soon
The ?flags query param will disappear as you go through the flow, but that's ok
Open network tools and preserve log to make it easier to inspect the call to /sites/new
Create a site with any plan other than ecommerce
Check that the call to /sites/new included a public_coming_soon=true option.
After site creation you should be taken to the editor (notice the launch button is missing, we'll fix that in Coming Soon: "launching" a site #45016)
Go to the site settings in calypso and see that the site is public but with indexing disabled
Create a new ecommerce with with the ?flags=gutenboarding/public-coming-soon flag set, it should still be created public and indexable
Create new sites without the ?flags flag set, it should behave as before
Were you redirected to the correct place after gutenboarding? Even after going through the checkout? For ecommerce sites your site should go atomic and you should land on a store onboarding flow. For all other plans you should eventually drop into the editor.

matticbot · 2020-09-07T06:35:57Z

Test live: https://calypso.live/?branch=add/public-coming-soon-flag-dev-builds

matticbot · 2020-09-07T06:46:56Z

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~161 bytes added 📈 [gzipped])

name                 parsed_size           gzip_size
entry-gutenboarding       -648 B  (-0.0%)     +161 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

roo2 · 2020-09-10T02:47:01Z

client/landing/gutenboarding/stores/onboard/actions.ts

@@ -74,6 +74,7 @@ export function* createSite(
 				font_headings: selectedFonts.headings,
 			} ),
 			use_patterns: isEnabled( 'gutenboarding/use-patterns' ),
+			public_coming_soon: isEnabled( 'gutenboarding/public-coming-soon' ) || undefined,


this will need to be updated to the new flag name wpcom_public_coming_soon.

Is the || undefined necessary? that would be the same behavior as leaving it off wouldn't it?

this will need to be updated to the new flag name wpcom_public_coming_soon.

This is an API param so doesn't actually need to map directly to the site option. But maybe leaving out the wpcom_ when the name is so similar just makes it confusing.

Is the || undefined necessary?

It might not be. I wanted to leave out the param from the payload if it's disabled, but I didn't actually test that the || undefined was necessary.

Just to be clear sending public_coming_soon=false would still do the correct thing, I kinda just wanted to leave it off entirely though.

I saw the existing code was doing the ...( someBool && { ... } ) trick to leave out some options. So I switched to that instead.

ahh ok I see why it's neccessary 👍

roo2 · 2020-09-10T02:47:10Z

client/landing/gutenboarding/hooks/use-selected-plan.ts

+	);
+
+	if ( isEcommerce ) {
+		return 1; // Public and discoverable


I think you should use a named constant here instead of the number and comment e.g.

return PRIVACY_MODES.PUBLIC_AND_DISCOVERABLE

I see that the API defines the meaning of those numbers but it would be better to have something more formal here I think

Good call. I could define those constants in the @automattic/data-stores package and use them in the API type definition too.

ramonjd · 2020-09-15T05:13:39Z

I think this is good to go.

@lsl @roo2 Any objections to enabling the coming soon feature flag?

✅ Create a site with any plan other than ecommerce
✅ Check that the call to /sites/new included a public_coming_soon=true option.

✅ After site creation you should be taken to the editor (notice the launch button is missing, we'll fix that in #45016)
✅ Go to the site settings in calypso and see that the site is public but with indexing disabled

✅ Create a new ecommerce with with the ?flags=gutenboarding/public-coming-soon flag set, it should still be created public and indexable

✅ Create new sites without the ?flags flag set, it should behave as before

✅ Were you redirected to the correct place after gutenboarding? 🆗
✅ Even after going through the checkout? 🆗
✅ For ecommerce sites your site should go atomic and you should land on a store onboarding flow. 🆗
✅ For all other plans you should eventually drop into the editor.

lsl · 2020-09-15T05:22:42Z

client/landing/gutenboarding/stores/onboard/actions.ts

@@ -34,7 +34,9 @@ export function* createSite(
 	username: string,
 	languageSlug: string,
 	bearerToken?: string,
-	isPublicSite = false
+	visibility: number = isEnabled( 'gutenboarding/public-coming-soon' )
+		? Site.Visibility.PublicNotIndexed


Is this defaulting sites to the not indexed option?

e: swapped out on launch maybe?
e2: never mind caught up now #45019

Yep. This default argument is never actually used (a value is always passed it), but sites in coming soon mode start as unindexed.

The setting will actually come from here: https://github.com/Automattic/wp-calypso/pull/45428/files#diff-6be59baa71efc91a49a8e47a21563362R55

roo2

Yep I've tested this with and without the feature flag and with ecommerce plan ✅ and the code looks good 👍

lsl

Tested, LGTM

Ecommerce sites aren't currently private-by-default, and also shouldn't use the new coming soon feature.

To silence warning that broke unit tests

The site was being created before the `useSelectedPlan` hook could update, which meant the plan passed to the `createSite` action wasn't up to date.

p-jackson added [Status] In Progress Coming Soon labels Sep 7, 2020

p-jackson self-assigned this Sep 7, 2020

p-jackson force-pushed the add/public-coming-soon-flag-dev-builds branch 2 times, most recently from 79853fb to 4f2ba2b Compare September 7, 2020 20:31

p-jackson mentioned this pull request Sep 7, 2020

Coming Soon: set up coming soon on site creation #45019

Closed

3 tasks

p-jackson force-pushed the add/public-coming-soon-flag-dev-builds branch 2 times, most recently from 28aaa96 to 211ec35 Compare September 9, 2020 05:16

roo2 reviewed Sep 10, 2020

View reviewed changes

p-jackson force-pushed the add/public-coming-soon-flag-dev-builds branch 2 times, most recently from 8c1f45a to 7a25d18 Compare September 10, 2020 10:07

p-jackson marked this pull request as ready for review September 10, 2020 10:55

p-jackson added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Sep 10, 2020

roo2 assigned roo2 and unassigned p-jackson Sep 15, 2020

ramonjd requested a review from a team September 15, 2020 04:25

ramonjd force-pushed the add/public-coming-soon-flag-dev-builds branch from 9f64d7e to 3077113 Compare September 15, 2020 05:02

lsl reviewed Sep 15, 2020

View reviewed changes

roo2 approved these changes Sep 15, 2020

View reviewed changes

lsl approved these changes Sep 15, 2020

View reviewed changes

p-jackson added 6 commits September 16, 2020 10:54

Send public_coming_soon site creation flag in development builds

8c65086

Do not set new coming soon sites as private-by-default

65366ce

Ecommerce sites aren't currently private-by-default, and also shouldn't use the new coming soon feature.

Define constants for site visibility options

e0f25f0

Disable indexing on new coming soon sites

46e8d2b

Add missing useCallback dependency

88686d6

To silence warning that broke unit tests

Ensure sites are only created after hooks have a chance to update

5dec8e9

The site was being created before the `useSelectedPlan` hook could update, which meant the plan passed to the `createSite` action wasn't up to date.

Ensure user is redirected to the correct place after gutenboarding flow

b994df8

p-jackson force-pushed the add/public-coming-soon-flag-dev-builds branch from 3077113 to b994df8 Compare September 15, 2020 22:58

roo2 merged commit c88eb9b into master Sep 15, 2020

roo2 deleted the add/public-coming-soon-flag-dev-builds branch September 15, 2020 23:25

matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 15, 2020

lsl mentioned this pull request Sep 16, 2020

Add/comingsoon v2 calypso #45606

Closed

ramonjd mentioned this pull request Oct 1, 2020

Coming Soon: update Gutenboarding coming soon flag #46076

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Coming soon: Send `public_coming_soon` site creation flag in development builds #45428

Coming soon: Send `public_coming_soon` site creation flag in development builds #45428

p-jackson commented Sep 7, 2020 •

edited

Loading

matticbot commented Sep 7, 2020

matticbot commented Sep 7, 2020 •

edited

Loading

roo2 Sep 10, 2020

p-jackson Sep 10, 2020

p-jackson Sep 10, 2020

p-jackson Sep 10, 2020

roo2 Sep 10, 2020

roo2 Sep 10, 2020

p-jackson Sep 10, 2020

ramonjd commented Sep 15, 2020

lsl Sep 15, 2020 •

edited

Loading

p-jackson Sep 15, 2020

p-jackson Sep 15, 2020

roo2 left a comment

lsl left a comment

Coming soon: Send public_coming_soon site creation flag in development builds #45428

Coming soon: Send public_coming_soon site creation flag in development builds #45428

Conversation

p-jackson commented Sep 7, 2020 • edited Loading

Changes proposed in this Pull Request

Testing instructions

matticbot commented Sep 7, 2020

matticbot commented Sep 7, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ramonjd commented Sep 15, 2020

lsl Sep 15, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

roo2 left a comment

Choose a reason for hiding this comment

lsl left a comment

Choose a reason for hiding this comment

Coming soon: Send `public_coming_soon` site creation flag in development builds #45428

Coming soon: Send `public_coming_soon` site creation flag in development builds #45428

p-jackson commented Sep 7, 2020 •

edited

Loading

matticbot commented Sep 7, 2020 •

edited

Loading

lsl Sep 15, 2020 •

edited

Loading