Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split coming soon from private site badge #45894

Closed
wants to merge 1 commit into from

Conversation

lsl
Copy link
Contributor

@lsl lsl commented Sep 24, 2020

Changes proposed in this Pull Request

Testing instructions

Fixes #

@matticbot
Copy link
Contributor

@lsl lsl self-assigned this Sep 24, 2020
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~114 bytes removed 📉 [gzipped])

name                    parsed_size           gzip_size
zoninator                     +73 B  (+0.0%)       -2 B  (-0.0%)
wp-super-cache                +73 B  (+0.0%)       -2 B  (-0.0%)
woocommerce                   +73 B  (+0.0%)       -2 B  (-0.0%)
themes                        +73 B  (+0.0%)       -2 B  (-0.0%)
theme                         +73 B  (+0.0%)       -2 B  (-0.0%)
stats                         +73 B  (+0.0%)       -2 B  (-0.0%)
sites                         +73 B  (+0.1%)       -2 B  (-0.0%)
site-purchases                +73 B  (+0.0%)       -2 B  (-0.0%)
site-blocks                   +73 B  (+0.0%)       -2 B  (-0.0%)
settings-writing              +73 B  (+0.0%)       -2 B  (-0.0%)
settings-security             +73 B  (+0.0%)       -2 B  (-0.0%)
settings-performance          +73 B  (+0.0%)       -2 B  (-0.0%)
settings-jetpack              +73 B  (+0.0%)       -2 B  (-0.0%)
settings-discussion           +73 B  (+0.0%)       -2 B  (-0.0%)
settings                      +73 B  (+0.0%)       -2 B  (-0.0%)
sensei                        +73 B  (+0.1%)       -2 B  (-0.0%)
security                      +73 B  (+0.0%)       -2 B  (-0.0%)
scan                          +73 B  (+0.0%)       -2 B  (-0.0%)
reader                        +73 B  (+0.0%)       -2 B  (-0.0%)
purchases                     +73 B  (+0.0%)       -2 B  (-0.0%)
privacy                       +73 B  (+0.0%)       -2 B  (-0.0%)
preview                       +73 B  (+0.0%)       -2 B  (-0.0%)
posts-custom                  +73 B  (+0.0%)       -2 B  (-0.0%)
posts                         +73 B  (+0.0%)       -2 B  (-0.0%)
post-editor                   +73 B  (+0.0%)       -2 B  (-0.0%)
plugins                       +73 B  (+0.0%)       -2 B  (-0.0%)
plans                         +73 B  (+0.0%)       -2 B  (-0.0%)
people                        +73 B  (+0.0%)       -2 B  (-0.0%)
pages                         +73 B  (+0.0%)       -2 B  (-0.0%)
notification-settings         +73 B  (+0.0%)       -2 B  (-0.0%)
migrate                       +73 B  (+0.0%)       -2 B  (-0.0%)
media                         +73 B  (+0.0%)       -2 B  (-0.0%)
me                            +73 B  (+0.0%)       -2 B  (-0.0%)
marketing                     +73 B  (+0.0%)       -2 B  (-0.0%)
jetpack-connect               +73 B  (+0.0%)       -2 B  (-0.0%)
jetpack-cloud-settings        +73 B  (+0.0%)       -2 B  (-0.0%)
jetpack-cloud                 +73 B  (+0.1%)       -2 B  (-0.0%)
import                        +73 B  (+0.0%)       -2 B  (-0.0%)
hosting                       +73 B  (+0.0%)       -2 B  (-0.0%)
home                          +73 B  (+0.0%)       -2 B  (-0.0%)
help                          +73 B  (+0.0%)       -2 B  (-0.0%)
hello-dolly                   +73 B  (+0.1%)       -2 B  (-0.0%)
happychat                     +73 B  (+0.0%)       -2 B  (-0.0%)
gutenberg-editor              +73 B  (+0.0%)       -2 B  (-0.0%)
google-my-business            +73 B  (+0.0%)       -2 B  (-0.0%)
export                        +73 B  (+0.0%)       -2 B  (-0.0%)
email                         +73 B  (+0.0%)       -2 B  (-0.0%)
earn                          +73 B  (+0.0%)       -2 B  (-0.0%)
domains                       +73 B  (+0.0%)       -2 B  (-0.0%)
customize                     +73 B  (+0.0%)       -2 B  (-0.0%)
concierge                     +73 B  (+0.0%)       -2 B  (-0.0%)
comments                      +73 B  (+0.0%)       -2 B  (-0.0%)
checkout                      +73 B  (+0.0%)       -2 B  (-0.0%)
backup                        +73 B  (+0.0%)       -2 B  (-0.0%)
activity                      +73 B  (+0.0%)       -2 B  (-0.0%)
account-close                 +73 B  (+0.0%)       -2 B  (-0.0%)
account                       +73 B  (+0.0%)       -2 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~10 bytes removed 📉 [gzipped])

name                                         parsed_size           gzip_size
async-load-signup-steps-site-picker                +73 B  (+0.1%)       -2 B  (-0.0%)
async-load-design-blocks                           +73 B  (+0.0%)       -2 B  (-0.0%)
async-load-components-web-preview-component        +73 B  (+0.0%)       -2 B  (-0.0%)
async-load-components-sites-popover                +73 B  (+0.1%)       -2 B  (-0.0%)
async-load-blocks-inline-help-popover              +73 B  (+0.0%)       -2 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@lsl lsl added Coming Soon [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Sep 25, 2020
@lsl
Copy link
Contributor Author

lsl commented Nov 20, 2020

I think @ramonjd merged this somewhere else

@lsl lsl closed this Nov 20, 2020
@lsl lsl deleted the update/separate-coming-soon-badge branch November 20, 2020 06:01
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 20, 2020
@ramonjd
Copy link
Member

ramonjd commented Nov 20, 2020

Ah thanks, yes I did. 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants