Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketplace: Show 3pd plugin terms #62072

Merged
merged 4 commits into from
Mar 22, 2022
Merged

Marketplace: Show 3pd plugin terms #62072

merged 4 commits into from
Mar 22, 2022

Conversation

epeicher
Copy link
Contributor

@epeicher epeicher commented Mar 18, 2022

Changes proposed in this Pull Request

Free plugins Plugin Details
CleanShot 2022-03-21 at 17 06 32@2x
  • For marketplace plugins it will not be displayed the Plugin Details but it will be in the Checkout screen:
Plugin Details Checkout
CleanShot 2022-03-21 at 17 09 27@2x CleanShot 2022-03-21 at 17 10 18@2x

Testing instructions

  • Select a Business or eCommerce site
  • Go to Plugins and select a Free plugin
  • Make sure you can click on the Third-Party plugin Terms link under the CTA button and navigate to the following page
  • Go back to the Plugins list page and select a Premium plugin
  • Check that there are no Terms of Service clauses under the CTA button
  • Click on Purchase and activate
  • Make sure there are clauses for WordPress.com Terms of Service and for Third-Party Plugins Terms of Service and you can navigate to the corresponding pages.

Closes #61607

@github-actions
Copy link

github-actions bot commented Mar 18, 2022

@matticbot
Copy link
Contributor

matticbot commented Mar 18, 2022

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~299 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
checkout      +1194 B  (+0.1%)     +267 B  (+0.1%)
plugins        +161 B  (+0.0%)      +32 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~448 bytes added 📈 [gzipped])

name                                             parsed_size           gzip_size
async-load-calypso-my-sites-checkout-modal           +1194 B  (+0.1%)     +277 B  (+0.1%)
async-load-calypso-blocks-editor-checkout-modal      +1194 B  (+0.1%)     +283 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@epeicher epeicher marked this pull request as ready for review March 21, 2022 16:22
@epeicher epeicher requested a review from a team as a code owner March 21, 2022 16:22
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 21, 2022
Copy link
Member

@sirbrillig sirbrillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it (I leave that to your team) but the code looks good to me and I have no concerns from a Payments perspective. 👍

Copy link
Contributor

@cpapazoglou cpapazoglou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and LGTM!

@epeicher epeicher merged commit 9e389d2 into trunk Mar 22, 2022
@epeicher epeicher deleted the add/third-party-tos branch March 22, 2022 12:23
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 22, 2022
@a8ci18n
Copy link

a8ci18n commented Mar 22, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7200926

Thank you @epeicher for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Mar 31, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marketplace: Show 3pd plugin terms
5 participants