Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Woo Onboarding: Add email verification functionality #64491

Merged
merged 7 commits into from
Jun 13, 2022

Conversation

sixhours
Copy link
Contributor

@sixhours sixhours commented Jun 9, 2022

Proposed Changes

  • Clicking on the "Resend email verification" button should send a verification email.
  • If the email has already been verified or if there's another failure, an error message should be displayed.
  • The button text should change to provide user feedback.

Visuals

Screen.Recording.2022-06-09.at.10.00.15.AM.mov

Screen Shot 2022-06-09 at 10 15 48 AM

Testing Instructions

  • Switch to this PR, navigate to /setup/wooVerifyEmail?siteSlug=[your site slug]&flags=signup/woo-verify-email
  • Test both with an account that has not yet been verified and one that has.
  • If the email needs verification, the button should display "Sending..." then "Request sent!"
  • If the email can't be verified, an error message should be shown.

Fixes #64163 #64461

@sixhours sixhours requested a review from a team June 9, 2022 13:56
@sixhours sixhours self-assigned this Jun 9, 2022
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 9, 2022
@github-actions
Copy link

github-actions bot commented Jun 9, 2022

@matticbot
Copy link
Contributor

matticbot commented Jun 9, 2022

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~218 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper       +707 B  (+0.0%)     +218 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~44 bytes added 📈 [gzipped])

name                      parsed_size           gzip_size
woocommerce-installation       +178 B  (+0.1%)      +44 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@sixhours
Copy link
Contributor Author

sixhours commented Jun 9, 2022

We may want to break the sendVerification function out into a shared hook since we'll need it elsewhere in both Stepper and possibly Calypso.

Copy link
Contributor

@markbiek markbiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as expected. LGTM!

@sixhours sixhours merged commit 72dfb6c into trunk Jun 13, 2022
@sixhours sixhours deleted the add/email-verify-button-function branch June 13, 2022 16:18
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 13, 2022
@a8ci18n
Copy link

a8ci18n commented Jun 13, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7375732

Thank you @sixhours for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Jun 22, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Woo Email Confirmation - Trigger email resend on button click
4 participants