Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stepper Seller Experience - Cleanup email field UX on Store Address step #65036

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Stepper Seller Experience - Cleanup email field UX on Store Address step #65036

merged 1 commit into from
Jun 28, 2022

Conversation

markbiek
Copy link
Contributor

Proposed Changes

We've updated the label to make the purpose of the email address more clean and added a button to allow the user to easily use their WordPress.com email.

image

Testing Instructions

Fixes #64202

@markbiek markbiek added [Feature Group] Customer Seller Experience The customer experience when purchasing services or products. Stepper labels Jun 28, 2022
@markbiek markbiek requested a review from a team June 28, 2022 14:55
@markbiek markbiek self-assigned this Jun 28, 2022
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 28, 2022
@github-actions
Copy link

github-actions bot commented Jun 28, 2022 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-36497
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-36497&env=jetpack

@matticbot
Copy link
Contributor

matticbot commented Jun 28, 2022 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~81 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper       +299 B  (+0.0%)      +81 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

sixhours
sixhours requested changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@sixhours sixhours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! I made a couple notes inline, and had a question about the UI behavior for this link:

Screen Shot 2022-06-28 at 12 18 34 PM

This should probably have a cursor change on hover to indicate you can click on it. It's styled like a link so I expected it to behave like one.

client/landing/stepper/declarative-flow/internals/steps-repository/store-address/index.tsx Outdated Show resolved Hide resolved
@markbiek markbiek force-pushed the 64202-update/store-address-email-field branch from d71c0f6 to 88563f0 Compare June 28, 2022 16:58
@markbiek
Cleanup email field UX on Store Address step
d52fb99 
We've updated the label to make the purpose of the email address more
clean and added a button to allow the user to easily use their
WordPress.com email.
@markbiek markbiek force-pushed the 64202-update/store-address-email-field branch from 88563f0 to d52fb99 Compare June 28, 2022 16:59
@markbiek markbiek added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Jun 28, 2022
@markbiek
Copy link
Contributor Author

@sixhours Thanks for the feedback! Those have all been addressed 🙏

@sixhours sixhours self-requested a review June 28, 2022 17:02
sixhours
sixhours approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@sixhours sixhours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@markbiek markbiek merged commit f94f86a into trunk Jun 28, 2022
@markbiek markbiek deleted the 64202-update/store-address-email-field branch June 28, 2022 17:14
@github-actions github-actions bot removed [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jun 28, 2022
@a8ci18n
Copy link

a8ci18n commented Jun 28, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7404640

Thank you @markbiek for including a screenshot in the description! This is really helpful for our translators.

bangank36 pushed a commit that referenced this pull request Jun 29, 2022
@markbiek @bangank36
Cleanup email field UX on Store Address step (#65036)
0e0297e 
We've updated the label to make the purpose of the email address more
clean and added a button to allow the user to easily use their
WordPress.com email.
ddc22 pushed a commit that referenced this pull request Jun 30, 2022
@markbiek @ddc22
Cleanup email field UX on Store Address step (#65036)
18df34f 
We've updated the label to make the purpose of the email address more
clean and added a button to allow the user to easily use their
WordPress.com email.
@a8ci18n
Copy link

a8ci18n commented Jul 11, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sixhours sixhours sixhours approved these changes

Assignees

@markbiek markbiek

Labels
[Feature Group] Customer Seller Experience The customer experience when purchasing services or products. Stepper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Woo Onboarding: Do we need the email address field?
4 participants
@markbiek @matticbot @a8ci18n @sixhours