Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified Design Picker: Theme Preview recognizes individual premium theme purchases #66239

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

mreishus
Copy link
Contributor

@mreishus mreishus commented Aug 3, 2022

Proposed Changes

  • When using the Unified Design Picker and previewing an individual premium theme, check to see if that theme has been purchased when deciding to display the "Unlock " button

Current behavior
2022-08-03_16-06

With this PR
2022-08-03_16-11

Testing Instructions

  • Have a free site with an individual premium theme purchased
  • Go to /setup/designSetup?siteSlug=<SITE_SLUG>&flags=signup/seller-upgrade-modal (note the flag)
  • Find a Premium theme you have purchased, and click on it to preview
  • The top right button should say "Start with ThemeName" and not "Unlock"
  • Click back, and this time click on a Premium theme you have not purchased
  • The top right button should continue to say "Unlock"

Related to #65857 #66187

@github-actions
Copy link

github-actions bot commented Aug 3, 2022

@mreishus mreishus self-assigned this Aug 3, 2022
@mreishus mreishus marked this pull request as ready for review August 3, 2022 21:20
@mreishus mreishus requested a review from a team August 3, 2022 21:21
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 3, 2022
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~4990 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper     +19565 B  (+0.5%)    +4990 B  (+0.5%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@markbiek markbiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mreishus mreishus merged commit 9f159cd into trunk Aug 4, 2022
@mreishus mreishus deleted the add/udp-theme-preview-detects-purchases branch August 4, 2022 14:23
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants