Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Product Lightbox styling #67221

Merged
merged 18 commits into from
Sep 5, 2022

Conversation

andrii-lysenko
Copy link
Contributor

@andrii-lysenko andrii-lysenko commented Aug 31, 2022

Proposed Changes

This PR adds Styling for the LightBox for Product Cards. It has hardcoded content, so it would be the same for each card. The most accent is done for responsiveness and following the designs.

Testing Instructions

Please test designs thorough on different screens (desktop/mobile, portrait/landscape). I would also appreciate any suggestions regarding improving CSS if needs one. Please don't look into content and it's behavior.

OR

  • use the jetpack cloud live link and goto `/pricing?flags=jetpack/pricing-page-product-lightbox

  • On product cards click on the question mark button at the bottom right of the card and observe the styling of the lightbox.

Screen.Recording.2022-09-01.at.18.41.45.mov

Pre-merge Checklist

Related to #
1202796695664022-as-1202900224232205/f


@andrii-lysenko andrii-lysenko added Jetpack [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR labels Aug 31, 2022
@github-actions
Copy link

github-actions bot commented Aug 31, 2022

@github-actions github-actions bot added the [Status] Design Input Requested Label automatically added to PRs where design feedback is requested label Aug 31, 2022
@matticbot
Copy link
Contributor

matticbot commented Aug 31, 2022

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~3993 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
jetpack-cloud-pricing     +15552 B  (+2.9%)    +4746 B  (+3.1%)
jetpack-connect           +15180 B  (+1.5%)    +4664 B  (+1.8%)
plans                     +11990 B  (+1.3%)    +3911 B  (+1.5%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@andrii-lysenko andrii-lysenko changed the title Update/jetpack product lightbox product data Add Product Lightbox styling Sep 1, 2022
@andrii-lysenko andrii-lysenko requested a review from a team September 1, 2022 15:44
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 1, 2022
@andrii-lysenko andrii-lysenko marked this pull request as ready for review September 1, 2022 15:45
Copy link
Contributor

@elliottprogrammer elliottprogrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lightbox is looking nice! However I am seeing most of the typography styles seem to off, comparing to the figma design here: m0y1jHTuDpvMPkFsOJBoNP-fi-3346%3A63755
Am I looking at the correct figma doc? 🤔

Here is a screenshot showing the current style values, and then to the right of the value I put a --> symbol showing what the value should be:

Markup 2022-09-01 at 20 02 50

@andrii-lysenko
Copy link
Contributor Author

Thanks @elliottprogrammer I will check these out. I will notice that I was mostly relying on styles in Codepen as I understood it's a newer version. And also some changes comes from this conversation -> p1661963115770459-slack-C03RCHNVC0H

Copy link
Contributor

@elliottprogrammer elliottprogrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for updating the typography styles. Looks great!
LGTM!! 👍

@andrii-lysenko andrii-lysenko merged commit 84248bf into trunk Sep 5, 2022
@andrii-lysenko andrii-lysenko deleted the update/jetpack-product-lightbox-product-data branch September 5, 2022 09:27
@github-actions github-actions bot removed [Status] Design Input Requested Label automatically added to PRs where design feedback is requested [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Sep 5, 2022
@a8ci18n
Copy link

a8ci18n commented Sep 14, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7527533

Hi @andrii-lysenko, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:

  • Great for:
  • Includes
  • Benefits

Thank you in advance!

@a8ci18n
Copy link

a8ci18n commented Sep 21, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants