-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Product Lightbox styling #67221
Add Product Lightbox styling #67221
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~3993 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lightbox is looking nice! However I am seeing most of the typography styles seem to off, comparing to the figma design here: m0y1jHTuDpvMPkFsOJBoNP-fi-3346%3A63755
Am I looking at the correct figma doc? 🤔
Here is a screenshot showing the current style values, and then to the right of the value I put a -->
symbol showing what the value should be:
Thanks @elliottprogrammer I will check these out. I will notice that I was mostly relying on styles in Codepen as I understood it's a newer version. And also some changes comes from this conversation -> p1661963115770459-slack-C03RCHNVC0H |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for updating the typography styles. Looks great!
LGTM!! 👍
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7527533 Hi @andrii-lysenko, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:
Thank you in advance! |
Translation for this Pull Request has now been finished. |
Proposed Changes
This PR adds Styling for the LightBox for Product Cards. It has hardcoded content, so it would be the same for each card. The most accent is done for responsiveness and following the designs.
Testing Instructions
Please test designs thorough on different screens (desktop/mobile, portrait/landscape). I would also appreciate any suggestions regarding improving CSS if needs one. Please don't look into content and it's behavior.
git fetch && git checkout update/jetpack-product-lightbox-product-data
yarn start-jetpack-cloud
OR
use the jetpack cloud live link and goto `/pricing?flags=jetpack/pricing-page-product-lightbox
On product cards click on the question mark button at the bottom right of the card and observe the styling of the lightbox.
Screen.Recording.2022-09-01.at.18.41.45.mov
Pre-merge Checklist
Related to #
1202796695664022-as-1202900224232205/f