Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datacenter Picker: Minor UI tweaks and soft-launch #70649

Merged
merged 4 commits into from
Dec 1, 2022

Conversation

danielbachhuber
Copy link
Contributor

See https://github.com/Automattic/dotcom-forge/issues/1239

Proposed Changes

  1. Uses US West, etc. as the labels, per feedback pdKhl6-15J-p2#comment-1472
  2. Only shows the primary data center in 'Web Server Settings' when it was chosen, and displays as a text input pdKhl6-15J-p2#comment-1479
  3. Removes the feature flag for a soft launch.

image

image

Testing Instructions

  1. Create a new WordPress.com site with a business plan.
  2. Navigate to 'Hosting Configuration' and click 'Activate'.
  3. Verify the <EligibilityWarnings> component displays with the Data Center Picker UI.
  4. Verify the Data Center Picker UI is usable, accessible, and looks good in the browsers we support.
  5. Click 'Continue' and wait for the site to go Atomic.
  6. Look at the 'Web Server Settings' UI and verify it appears as expected.

@danielbachhuber danielbachhuber requested a review from a team December 1, 2022 13:45
@danielbachhuber danielbachhuber self-assigned this Dec 1, 2022
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 1, 2022
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~14 bytes removed 📉 [gzipped])

name                             parsed_size           gzip_size
hosting                               -237 B  (-0.0%)      -14 B  (-0.0%)
themes                                 -36 B  (-0.0%)      -17 B  (-0.0%)
settings-performance                   -36 B  (-0.0%)      -17 B  (-0.0%)
plugins                                -36 B  (-0.0%)      -17 B  (-0.0%)
jetpack-cloud-plugin-management        -36 B  (-0.0%)      -17 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@danielbachhuber danielbachhuber merged commit 389c766 into trunk Dec 1, 2022
@danielbachhuber danielbachhuber deleted the improve/datacenter-picker-soft-launch branch December 1, 2022 13:52
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 1, 2022
@a8ci18n
Copy link

a8ci18n commented Dec 1, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7649928

Thank you @danielbachhuber for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Dec 11, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants