Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use translate() only where needed #71234

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Use translate() only where needed #71234

merged 1 commit into from
Dec 15, 2022

Conversation

aidvu
Copy link
Contributor

@aidvu aidvu commented Dec 15, 2022

No need to translate() static version numbers. Also improve translation strings.

Screenshot from 2022-12-15 12-20-47

Screenshot from 2022-12-15 12-20-53

@aidvu aidvu requested a review from simison December 15, 2022 11:19
@aidvu aidvu self-assigned this Dec 15, 2022
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 15, 2022
@github-actions
Copy link

github-actions bot commented Dec 15, 2022

Copy link
Member

@simison simison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aidvu aidvu merged commit 8f36f29 into trunk Dec 15, 2022
@aidvu aidvu deleted the aidvu-patch-1 branch December 15, 2022 13:53
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 15, 2022
@a8ci18n
Copy link

a8ci18n commented Dec 15, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7674448

Thank you @aidvu for including a screenshot in the description! This is really helpful for our translators.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~6 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
hosting       -130 B  (-0.0%)       +6 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@a8ci18n
Copy link

a8ci18n commented Dec 23, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants