Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailored flows: fix newsletter description #71242

Merged
merged 2 commits into from
Dec 15, 2022
Merged

Conversation

alshakero
Copy link
Member

@alshakero alshakero commented Dec 15, 2022

Proposed Changes

  • Fixes: p1671115114168519-slack-C02T4NVL4JJ

Testing Instructions

  1. Go to NL flow in Desktop, it should look good.
  2. Go to NL flow in mobile, it should look good in all viewport sizes.

wordpress com_setup_newsletter_intro

@alshakero alshakero requested a review from a team December 15, 2022 16:19
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 15, 2022
@alshakero alshakero added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Dec 15, 2022
@github-actions
Copy link

github-actions bot commented Dec 15, 2022

Copy link
Contributor

@escapemanuele escapemanuele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and it works great 👍

@a8ci18n
Copy link

a8ci18n commented Dec 15, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7674580

Thank you @alshakero for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Dec 15, 2022

Translation for this Pull Request has now been finished.

@alshakero alshakero changed the title Tailored flows: fix newsletter desc Tailored flows: fix newsletter description Dec 15, 2022
@alshakero alshakero merged commit 0ed2a8a into trunk Dec 15, 2022
@alshakero alshakero deleted the fix/newsletter-desc branch December 15, 2022 18:59
@github-actions github-actions bot removed [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 15, 2022
@matticbot
Copy link
Contributor

matticbot commented Dec 22, 2022

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~8 bytes removed 📉 [gzipped])

name                     parsed_size           gzip_size
videopress-flow                -37 B  (-0.0%)       -4 B  (-0.0%)
tailored-ecommerce-flow        -37 B  (-0.0%)       -4 B  (-0.0%)
newsletter-flow                -37 B  (-0.0%)       -4 B  (-0.0%)
link-in-bio-flow               -37 B  (-0.0%)       -4 B  (-0.0%)
free-flow                      -37 B  (-0.0%)       -4 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants