Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users management: Update user details screen #71720

Merged
merged 3 commits into from
Jan 9, 2023
Merged

Conversation

bogiii
Copy link
Contributor

@bogiii bogiii commented Jan 5, 2023

Proposed Changes

  • Update copy
  • Team member edit form: Added title to match the User Details design
  • Introduced autosave functionality on team member edit form

Testing Instructions

  • Go to /people/team-members/{SITE_SLUG}
  • Click on the team member item
  • Try to edit the role or toggle the contractor checkbox
  • Check if autosave works

Known issues:

  • Updating the admin profile shows "There was an error updating..." but the change is saved (the same behavior is on production so it is not introduced with this PR)

Screenshots

Screenshot 2023-01-06 at 12 03 54

Screen Capture on 2023-01-06 at 11-59-07

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

Related to #71718

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

@bogiii bogiii self-assigned this Jan 5, 2023
@matticbot
Copy link
Contributor

matticbot commented Jan 5, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~59 bytes added 📈 [gzipped])

name    parsed_size           gzip_size
people       +186 B  (+0.0%)      +59 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@bogiii bogiii requested a review from a team January 6, 2023 11:38
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 6, 2023
@bogiii bogiii marked this pull request as ready for review January 6, 2023 11:41
@bogiii bogiii changed the title Update/users management 6 Users management: Update user details screen Jan 6, 2023
Copy link
Contributor

@ouikhuan ouikhuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bogiii bogiii merged commit fe25611 into trunk Jan 9, 2023
@bogiii bogiii deleted the update/users-management-6 branch January 9, 2023 17:28
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 9, 2023
@a8ci18n
Copy link

a8ci18n commented Jan 9, 2023

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7720776

Thank you @bogiii for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Jan 20, 2023

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants