Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'Paid' badge for marketplace themes #72815

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Use 'Paid' badge for marketplace themes #72815

merged 1 commit into from
Feb 1, 2023

Conversation

daledupreez
Copy link
Contributor

Proposed Changes

  • This PR explores updating the badge for marketplace themes to use Paid as the main label, and changes the color. Both changes should make it much easier to distinguish between premium and marketplace themes.
  • This change stems from the following internal discussion: pekYwv-Ax-p2

Testing Instructions

  • Apply this PR or open the Calypso.live branch
  • Navigate to Appearance -> Themes
  • Verify that marketplace themes have a blue label with Paid as the text
  • Mouse over the label, and verify that the tooltip header is now Paid theme

Screenshots

Badge in theme showcase

Screenshot 2023-01-31 at 11 10 46

Tooltip header

Screenshot 2023-01-31 at 11 23 52

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • [N/A] Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • [N/A] For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

Related to #72514

@daledupreez daledupreez added [Feature] Theme Showcase The theme showcase screen in Calypso in Appearance > Themes. Marketplace labels Jan 31, 2023
@daledupreez daledupreez self-assigned this Jan 31, 2023
@daledupreez daledupreez requested a review from a team January 31, 2023 09:27
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 31, 2023
@github-actions
Copy link

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:commit-c75b5876afc8348d8938f3a15d45c3ff202a2400
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:commit-c75b5876afc8348d8938f3a15d45c3ff202a2400&env=jetpack

@daledupreez daledupreez marked this pull request as ready for review February 1, 2023 08:50
@daledupreez daledupreez changed the title [Proposal] Use 'Paid' badge for marketplace themes Use 'Paid' badge for marketplace themes Feb 1, 2023
@daledupreez daledupreez requested a review from a team February 1, 2023 08:53
markbiek
markbiek approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@markbiek markbiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daledupreez daledupreez merged commit f46502c into trunk Feb 1, 2023
@daledupreez daledupreez deleted the update/marketplace-theme-badge-in-theme-showcase branch February 1, 2023 12:28
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 1, 2023
@a8ci18n
Copy link

a8ci18n commented Feb 1, 2023

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7787528

Thank you @daledupreez for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Feb 10, 2023

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markbiek markbiek markbiek approved these changes

Assignees

@daledupreez daledupreez

Labels
[Feature] Theme Showcase The theme showcase screen in Calypso in Appearance > Themes. Marketplace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daledupreez @a8ci18n @markbiek @matticbot