Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change .ca domains checkout option from Queen to King #73024

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Change .ca domains checkout option from Queen to King #73024

merged 1 commit into from
Feb 23, 2023

Conversation

jartes
Copy link
Contributor

@jartes jartes commented Feb 6, 2023 •
edited
Loading

Proposed Changes

  • Updates the "Canadian presence" on the checkout when registering a .ca domain from "Her Majesty the Queen" to "His Majesty the King".

Testing Instructions

  • On a Simple or Atomic site, go to Upgrades → Domains → Add a domain → Search for a domain.
  • Search for a domain with the .ca extension, and add it to the cart.
  • Go to the Checkout page and check that on the "Canadian presence" the last option is displayed as "His Majesty the King":

Markup on 2023-02-06 at 23:08:12

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

Fixes #72784

@jartes jartes requested a review from a team as a code owner February 6, 2023 22:12
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 6, 2023
@github-actions
Copy link

github-actions bot commented Feb 6, 2023 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-56370
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-56370&env=jetpack

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@jartes jartes added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Feb 6, 2023
@a8ci18n
Copy link

a8ci18n commented Feb 6, 2023

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7798003

Thank you @jartes for including a screenshot in the description! This is really helpful for our translators.

tyxla
tyxla approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on your first Calypso PR 👏

This looks good to me. Let's merge once it's translated for the rest of the languages.

@tyxla tyxla mentioned this pull request Feb 7, 2023
Closed
@a8ci18n
Copy link

a8ci18n commented Feb 16, 2023

Translation for this Pull Request has now been finished.

@tyxla
Copy link
Member

tyxla commented Feb 20, 2023

This is ready to deploy, @jartes! Let's do a Calypso deployment session together later this week if you're interested 🔴 🟢

@jartes
Copy link
Contributor Author

jartes commented Feb 21, 2023

@tyxla Great! Yeah, let's deploy it this week. I'll share my availability soon 📆

@tyxla tyxla merged commit 4eb5bdd into trunk Feb 23, 2023
@tyxla tyxla deleted the fix/72784-ca-domains-checkout-option branch February 23, 2023 12:39
@github-actions github-actions bot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyxla tyxla tyxla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Queen to King in domain checkout options
4 participants
@jartes @matticbot @a8ci18n @tyxla