Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop App: update Electron and related package versions. #78098

Merged
merged 11 commits into from
Jun 15, 2023
Merged

Desktop App: update Electron and related package versions. #78098

merged 11 commits into from
Jun 15, 2023

Conversation

worldomonation
Copy link
Contributor

@worldomonation worldomonation commented Jun 13, 2023 •
edited
Loading

Slack: p1686560269103799-slack-C7YPUHBB2
Supersedes #75516.

Proposed Changes

This PR updates the Desktop app to use more recent versions of packages. The goal is to move off deprecated versions that have security vulnerabilities.

Key changes:

  • update electron to 25.0.1.
  • update electron-builder to 23.0.3.
  • remove electron-rebuild.
  • update Windows signing key.

Testing Instructions

Ensure the following build configurations are passing in TeamCity:

  • Unit Tests
  • Code Style
  • Desktop E2E tests

Additionally, check on CircleCI:

  • wp-desktop-assets
  • wp-desktop-mac
  • wp-desktop-linux
  • wp-desktop-windows

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@worldomonation worldomonation self-assigned this Jun 13, 2023
@github-actions
Copy link

github-actions bot commented Jun 13, 2023 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-70310
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-70310&env=jetpack

wp-desktop
wp-desktop previously requested changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@wp-desktop wp-desktop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WordPress Desktop CI Failure for job "wp-desktop-mac".

@worldomonation please inspect this job's build steps for breaking changes at this link. For temporal failures, you may try to "Rerun Workflow from Failed".

Please also ensure this branch is rebased off latest Calypso.

@worldomonation worldomonation force-pushed the desktop/upgrade-electron-v25.0.1 branch from 93583e0 to 16305e2 Compare June 13, 2023 06:48
@matticbot
Copy link
Contributor

matticbot commented Jun 13, 2023 •
edited
Loading

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@wp-desktop wp-desktop dismissed their stale review June 13, 2023 08:07

wp-desktop ci passing, closing review

wp-desktop
wp-desktop previously requested changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@wp-desktop wp-desktop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WordPress Desktop CI Failure for job "wp-desktop-mac".

@worldomonation please inspect this job's build steps for breaking changes at this link. For temporal failures, you may try to "Rerun Workflow from Failed".

Please also ensure this branch is rebased off latest Calypso.

@wp-desktop wp-desktop dismissed their stale review June 13, 2023 15:51

wp-desktop ci passing, closing review

nsakaimbo and others added 3 commits June 14, 2023 01:10
@nsakaimbo @worldomonation
ci: re-enable mac build
f56865b 
ci: try xcode image 14.2.0

try pin node-abi to 3.35.0

update SDK target

set min mac target to 10.13

fix SDK target

refresh node

silence font warnings

fix secrets script

temp: sign Windows build

replace windows cert

remove -nopad arg

try alternate cert name

Revert "try alternate cert name"

This reverts commit 2f91dd3.

temp: install Windows cert

temp: build v6.9.9
@worldomonation
Update electron to 24.5.0
e6a7043 
Update electron-builder to 23.6.0
Set PLAYWRIGHT_SKIP_DOWNLOAD env var.
@worldomonation
Set PLAYWRIGHT_SKIP_DOWNLOAD: true for every job.
b357c55 
Update electron-builder to 24.2.0
@worldomonation worldomonation force-pushed the desktop/upgrade-electron-v25.0.1 branch from 27bfe12 to bf870d3 Compare June 13, 2023 16:28
@worldomonation
electron: 24.0.0
4ee2c16 
electron-builder: 23.0.3
@worldomonation worldomonation force-pushed the desktop/upgrade-electron-v25.0.1 branch from bf870d3 to 4ee2c16 Compare June 13, 2023 16:32
@worldomonation worldomonation changed the title Desktop/upgrade electron v25.0.1 Desktop App: update Electron and related package versions. Jun 14, 2023
@worldomonation
Copy link
Contributor Author

CircleCI builds are passing:

image

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 14, 2023
@worldomonation worldomonation marked this pull request as ready for review June 14, 2023 04:52
@worldomonation worldomonation added the [Feature] WordPress Desktop App Features and improvements related to the WordPress Desktop App. label Jun 14, 2023
wp-desktop
wp-desktop previously requested changes Jun 14, 2023
View reviewed changes
Copy link
Collaborator

@wp-desktop wp-desktop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WordPress Desktop CI Failure for job "wp-desktop-mac".

@nsakaimbo please inspect this job's build steps for breaking changes at this link. For temporal failures, you may try to "Rerun Workflow from Failed".

Please also ensure this branch is rebased off latest Calypso.

@nsakaimbo nsakaimbo force-pushed the desktop/upgrade-electron-v25.0.1 branch from 1427612 to 337c9f0 Compare June 14, 2023 18:04
@wp-desktop wp-desktop dismissed their stale review June 14, 2023 18:37

wp-desktop ci passing, closing review

nsakaimbo
nsakaimbo approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@nsakaimbo nsakaimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping get this update to the finish line, @worldomonation! I made a couple of small additional tweaks, as well smoke-tested the build on Windows. Looks good. Please 🚢.

@worldomonation worldomonation merged commit dfc1979 into trunk Jun 15, 2023
@worldomonation worldomonation deleted the desktop/upgrade-electron-v25.0.1 branch June 15, 2023 07:29
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 15, 2023
@nsakaimbo nsakaimbo mentioned this pull request Jun 23, 2023
Closed
11 tasks
@worldomonation worldomonation mentioned this pull request Jul 6, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsakaimbo nsakaimbo nsakaimbo approved these changes

@wp-desktop wp-desktop wp-desktop left review comments

Assignees

@worldomonation worldomonation

Labels
[Feature] WordPress Desktop App Features and improvements related to the WordPress Desktop App.
Projects
KitKat Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@worldomonation @matticbot @nsakaimbo @wp-desktop