Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domain transfers : Add a domain screen updates #79757

Merged
merged 5 commits into from
Jul 21, 2023
Merged

Domain transfers : Add a domain screen updates #79757

merged 5 commits into from
Jul 21, 2023

Conversation

agrullon95
Copy link
Contributor

@agrullon95 agrullon95 commented Jul 21, 2023 •
edited
Loading

Related to p1689953627135289-slack-C05CT832K2T

Proposed Changes

  • Update Domain name input field to 420px and Authorization code input field width to 240px on desktop viewport.
  • Add Please enter the domain name and authorization code placeholder for Domain name input field when input is empty.
  • Remove validation message under Domain Name input field when domain is validated.
  • Change Clear domain and Try domain color.
  • Change subtitle copy from (50 to fifty)
  • Update to display Transfer X domains for X$

Testing Instructions

  • Checkout this branch or use live link
  • Navigate to /setup/domain-transfer/domains
  • Verify proposed changes

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@agrullon95 agrullon95 requested review from paulopmt1, ebinnion and a team July 21, 2023 18:16
@agrullon95 agrullon95 self-assigned this Jul 21, 2023
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jul 21, 2023
@github-actions
Copy link

github-actions bot commented Jul 21, 2023 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-74738
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-74738&env=jetpack

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@agrullon95 agrullon95 added the [Feature Group] Emails & Domains Features related to email integrations and domain management. label Jul 21, 2023
lupus2k
lupus2k approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@lupus2k lupus2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

paulopmt1
paulopmt1 approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@paulopmt1 paulopmt1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @agrullon95!
I have one suggestion only related to maintaining compatibility with previous translations. After that, it's ready to ship!

  • The domains input field should be smaller (420px) and auth code input wider (240px) - so it matches the content better.
  • Add Please enter the domain name and authorization code placeholder for Domain name input field when input is empty.
  • Remove validation message under Domain Name input field when domain is validated.
  • Change Clear domain and Try domain color.
  • Change subtitle copy from (50 to fifty). Changed are good, missed compatibility check.
  • Update to display Transfer X domains for X$
  • Multi-browser check

...anding/stepper/declarative-flow/internals/steps-repository/domain-transfer-domains/index.tsx Outdated
@@ -30,7 +30,7 @@ const Intro: Step = function Intro( { navigation, flow } ) {
<>
<span>
{ __(
'Enter your domain names and authorization codes below. You can transfer up to 50 domains at a time.'
'Enter your domain names and authorization codes below. You can transfer up to fifty domains at a time.'
Copy link
Contributor

@paulopmt1 paulopmt1 Jul 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we still don't have translations for it. Can we use i18n.hasTranslation here? That way, it can work with the previous version while we receive the new strings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I addressed the translation changes.

paulopmt1
paulopmt1 reviewed Jul 21, 2023
View reviewed changes
Copy link
Contributor

@paulopmt1 paulopmt1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text compatibility is working great!

image

@agrullon95 agrullon95 merged commit b083cae into trunk Jul 21, 2023
3 checks passed
@agrullon95 agrullon95 deleted the update/domains-screen-2-0721 branch July 21, 2023 20:24
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 21, 2023
@a8ci18n
Copy link

a8ci18n commented Jul 21, 2023 •
edited
Loading

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/8603088

Hi @agrullon95, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:

  • Transfer for %s
  • Transfer for free
  • Transfer %1$s domains for %2$s
  • Enter your domain names and authorization codes below. You can transfer up to fifty domains at a time.

Thank you in advance!

@a8ci18n
Copy link

a8ci18n commented Jul 27, 2023

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulopmt1 paulopmt1 paulopmt1 approved these changes

@lupus2k lupus2k lupus2k approved these changes

@ebinnion ebinnion Awaiting requested review from ebinnion

Assignees

@agrullon95 agrullon95

Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@agrullon95 @matticbot @a8ci18n @lupus2k @paulopmt1