Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration flow: Remove FTP option from credential form in migration flow #85818

Merged
merged 4 commits into from
Dec 29, 2023

Conversation

ouikhuan
Copy link
Contributor

Related to #85704

Proposed Changes

  • Remove options for providing FTP credentials from the credential form screen (as this has no appreciable effect on performance).

Testing Instructions

  • Navigate to http://calypso.localhost:3000/setup/import-focused/import?siteSlug=ATOMIC_SITE_SLUG
  • Fill in a source site you'd like to migrate from, it can be a JN site.
  • Make the Jetpack connection if needed and once you land on the You are ready to migrate screen, click Provide the server credentials link.
  • Make sure you see SSH/SFTP as the default credential type in the form.
  • Make sure the port number is 22.
  • When you select credential type dropdown, there will be no FTP option.
Screen Shot 2023-12-28 at 3 27 30 PM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@ouikhuan ouikhuan self-assigned this Dec 28, 2023
@ouikhuan ouikhuan requested a review from a team as a code owner December 28, 2023 07:30
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 28, 2023
Copy link

github-actions bot commented Dec 28, 2023

@matticbot
Copy link
Contributor

matticbot commented Dec 28, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~132 bytes added 📈 [gzipped])

name                     parsed_size           gzip_size
import-hosted-site-flow       +163 B  (+0.0%)      +88 B  (+0.0%)
import-flow                   +163 B  (+0.0%)      +88 B  (+0.0%)
settings-jetpack               +66 B  (+0.0%)      +22 B  (+0.0%)
jetpack-cloud-settings         +66 B  (+0.0%)      +22 B  (+0.0%)
backup                         +66 B  (+0.0%)      +22 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@bogiii bogiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested and it works as described.
I left a comment about the small detail I found.

Also, the related ticket has action item:

  • "Automatically open the screen to provide SSH credentials if the customer is a developer"

Are we going to cover it in this PR or the next?

@ouikhuan
Copy link
Contributor Author

Also, the related ticket has action item:

  • "Automatically open the screen to provide SSH credentials if the customer is a developer"
    Are we going to cover it in this PR or the next?

Just for the record that since this is a different feature, we'll handle it in a separate PR 👍

@ouikhuan ouikhuan merged commit 5e89095 into trunk Dec 29, 2023
11 checks passed
@ouikhuan ouikhuan deleted the update/remove-ftp-option branch December 29, 2023 01:47
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 29, 2023
@a8ci18n
Copy link

a8ci18n commented Dec 29, 2023

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants