-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration flow: Remove FTP option from credential form in migration flow #85818
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~132 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested and it works as described.
I left a comment about the small detail I found.
Also, the related ticket has action item:
- "Automatically open the screen to provide SSH credentials if the customer is a developer"
Are we going to cover it in this PR or the next?
client/blocks/importer/wordpress/import-everything/pre-migration/credentials-form.tsx
Outdated
Show resolved
Hide resolved
60b3e82
to
c7ed495
Compare
Just for the record that since this is a different feature, we'll handle it in a separate PR 👍 |
Translation for this Pull Request has now been finished. |
Related to #85704
Proposed Changes
Testing Instructions
http://calypso.localhost:3000/setup/import-focused/import?siteSlug=ATOMIC_SITE_SLUG
You are ready to migrate
screen, clickProvide the server credentials
link.22
.Pre-merge Checklist