-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Site Editor)(wpcom-block-editor) Remove dotcom-specific Site Editor "manage all pages" click handler #87347
(Site Editor)(wpcom-block-editor) Remove dotcom-specific Site Editor "manage all pages" click handler #87347
Conversation
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
Hi @fullofcaffeine -- I haven't been in touch with the site editor side of Calypso in quite a while, but I don't immediately see any concerns with removing the override I've written From what I can tell based off of the originating PR, the implications are that the wp-admin site editor's back to dashboard button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fullofcaffeine, this looks good to me.
look into removing the
/wpcom/v2/admin-menu
endpoint and its code
That endpoint is still needed, since it powers how we build the left sidebar menu in both Calypso and WP Admin. I just decided to use it for this overriding behavior to determine whether the user prefers the classic view (WP Admin) of the default view (Calypso) for a particular menu item (Pages > All pages).
Thanks folks! |
Diff: D137905-code |
Proposed Changes
Proposal for fixing #87009.
Related to: #81509, where this override was introduced.
The definitive view should be the new "DataVIew" view from core. I'm not 100% this is the right solution, though, as the removed logic took into account settings that are available only in dotcom, so I'm not sure if we should deprecate it or fix it cc @mmtr
If this is truly deprecated code, then we should probably also look into removing the
/wpcom/v2/admin-menu
endpoint and its code. Finally, if that's the case, then it seems we could also remove the (related?) https://github.com/Automattic/wp-calypso/blob/trunk/apps/wpcom-block-editor/src/wpcom/features/override-edit-site-back-button.js module? cc @jeyipTesting Instructions
Considering you're running a dotcom WP simple instance with at least Gutenberg 17.6.2+ installed and active.
/wpcom/v2/admin-menu
, but I could reproduce it consistently;widgets.wp.com
;wp-calypso
copy, then go toapps/wpcom-block-editor
and runyarn dev --sync
to compile and sync it to your sandbox;