Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whats New: Make it on the center of the screen #88364

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

arthur791004
Copy link
Contributor

Related to #88324

Proposed Changes

  • Move the What's New modal to the center of the screen
Before After
image image

Testing Instructions

  • Go to your site with the nav redesign
  • Make sure the What's New modal is on the center of the screen. If the modal is not shown, you can open the Help Center and scroll down to click "What's new"

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

Copy link

github-actions bot commented Mar 11, 2024

@arthur791004 arthur791004 requested review from a team March 11, 2024 07:51
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 11, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • editing-toolkit
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug feat/center-whats-new-modal on your sandbox.

@arthur791004 arthur791004 self-assigned this Mar 11, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@arthur791004 arthur791004 merged commit 5474ce5 into trunk Mar 11, 2024
15 of 16 checks passed
@arthur791004 arthur791004 deleted the feat/center-whats-new-modal branch March 11, 2024 08:00
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 11, 2024
@roo2
Copy link
Contributor

roo2 commented Mar 12, 2024

With making it centered, we'd better make the background clickable again like p1709821089976579/1709762884.683639-slack-C06DN6QQVAQ

@roo2
Copy link
Contributor

roo2 commented Mar 13, 2024

openned #88438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants