Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription Site: Release the Subscribe block after the post placement toggle #88702

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

pkuliga
Copy link
Contributor

@pkuliga pkuliga commented Mar 20, 2024

Related to peKye1-EA-p2

Proposed Changes

It:

  • releases the Subscription block at the end of each post placement toggle to prod
  • hides the "Preview and edit" link for this toggle. We'll show it when the WP Core 6.5 is released
Screenshot 2024-03-20 at 13 41 07

Testing Instructions

  1. Go to Newsletter Settings
  2. Make sure the "Add the Subscribe Block at the end of each post." toggle is visible and works as expected

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@pkuliga pkuliga added the [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. label Mar 20, 2024
@matticbot
Copy link
Contributor

matticbot commented Mar 20, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/subscription-site-release on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Mar 20, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~83 bytes removed 📉 [gzipped])

name                 parsed_size           gzip_size
settings-newsletter       -396 B  (-0.1%)      -83 B  (-0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@pkuliga pkuliga changed the title Subscription Site: Release Subscription Site: Release the Subscribe block after the post placement toggle Mar 20, 2024
@pkuliga pkuliga requested a review from a team March 20, 2024 15:07
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 20, 2024
Copy link
Member

@simison simison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 let's go

@pkuliga pkuliga merged commit 1e4e22c into trunk Mar 28, 2024
11 checks passed
@pkuliga pkuliga deleted the update/subscription-site-release branch March 28, 2024 12:55
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 28, 2024
jeyip pushed a commit that referenced this pull request Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants