Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site Migration: Skip bundle transfer step #90164

Closed
wants to merge 1 commit into from
Closed

Site Migration: Skip bundle transfer step #90164

wants to merge 1 commit into from

Conversation

gabrielcaires
Copy link
Contributor

@gabrielcaires gabrielcaires commented May 1, 2024 •
edited
Loading

Related to #90146

Proposed Changes

  • Redirect the user directly to the migration screen page when the 'migration-flow/remove-processing-step' is enabled

Note

We need to double-check the verify-email step

Testing Instructions

  • Enable the flag via sessionStorage.setItem('flags', "migration-flow/remove-processing-step")
  • Select a free plan
  • Go through the migration steps
  • Choose Everything (requires a Creator Plan)
  • When you arrive on the checkout page, check if the URL contains the value site-migration-instructions-i2
  • Finish the payment
  • Check if you were redirected directly to the setup/site-migration/site-migration-instructions-i2

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@gabrielcaires gabrielcaires requested a review from a team May 1, 2024 15:42
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2024 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-106046
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-106046&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-106046&env=a8c-for-agencies

@gabrielcaires gabrielcaires marked this pull request as ready for review May 1, 2024 15:42
gabrielcaires
gabrielcaires commented May 1, 2024
View reviewed changes
client/landing/stepper/declarative-flow/test/site-migration-flow.tsx
@@ -18,6 +20,19 @@ const originalLocation = window.location;
jest.mock( '../../utils/checkout' );
jest.mock( '@automattic/data-stores/src/user/selectors' );
jest.mock( 'calypso/landing/stepper/hooks/use-is-site-owner' );
jest.mock( '../../utils/path', () => {
return {
getLoginUrl: jest.fn(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is required because the getLoginUrl() returns different values based on the feature flag, so when I mock the feature flags value it breaks the tests.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~5 bytes removed 📉 [gzipped])

name                 parsed_size           gzip_size
site-migration-flow        -31 B  (-0.1%)       -5 B  (-0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@gabrielcaires gabrielcaires added the [Feature] Site Migration Features related to site migrations to WPcom label May 2, 2024
@nelsonec87
Copy link
Contributor

It is working as described! There are conflicts, though.

@markbiek
Copy link
Contributor

It is working as described! There are conflicts, though.

I think the conflicts are related to #90663

@gabrielcaires gabrielcaires mentioned this pull request May 16, 2024
Merged
7 tasks
@gabrielcaires
Copy link
Contributor Author

gabrielcaires commented May 21, 2024 •
edited
Loading

Closing the PR because it was already implemented in on #90712

@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 21, 2024
@markbiek
Copy link
Contributor

Closing the PR because it was already implemented in on #90712

Sorry you did that work for nothing. It looks like we ended up with two issues for the same thing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Feature] Site Migration Features related to site migrations to WPcom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabrielcaires @matticbot @nelsonec87 @markbiek