-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entrepreneur Signup: Remember path to last step during trial acknowledgement. #91119
Entrepreneur Signup: Remember path to last step during trial acknowledgement. #91119
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~60 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
...Object.fromEntries( queryParams ), | ||
} | ||
); | ||
const redirectTo = `${ window.location.protocol }//${ window.location.host }/setup/entrepreneur/trialAcknowledge${ window.location.search }`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just the simplify the code here (and fix an existing bug where ?ref=
is not inherited after redirection from signing-up.
452f099
to
2017779
Compare
Related to #
Proposed Changes
Why are these changes being made?
Testing Instructions
/setup/entrepreneur?ref=entrepreneur-signup
.preferences
API call in the network panel.entrepreneur-flow-path-step-<user_id>
being stored.Pre-merge Checklist