Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entrepreneur Signup: Remember path to last step during trial acknowledgement. #91119

Merged
merged 2 commits into from
May 27, 2024

Conversation

yansern
Copy link
Contributor

@yansern yansern commented May 24, 2024

Related to #

⚠️ This is currently a fork of this PR. #91113

Proposed Changes

  • Store the path to come back to after email verification during trial acknowledgement step.
  • The path is stored in Calypso preferences.

Why are these changes being made?

  • So that users can come back to the trial acknowledgement step after clicking email verification link.

Testing Instructions

  • Open incognito window (as this is only for unverified users).
  • Open network panel.
  • Go to /setup/entrepreneur?ref=entrepreneur-signup.
  • Create an account (or login into an unverified account).
  • When you arrive at the Trial Acknowledge step, look for POST preferences API call in the network panel.
  • You should see the key entrepreneur-flow-path-step-<user_id> being stored.
2024-05-24_21-58-02

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@yansern yansern requested a review from a team May 24, 2024 14:02
@yansern yansern self-assigned this May 24, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 24, 2024
@yansern yansern changed the base branch from trunk to add/entrepreneur-trial-page May 24, 2024 14:03
@matticbot
Copy link
Contributor

matticbot commented May 24, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~60 bytes added 📈 [gzipped])

name                     parsed_size           gzip_size
import-hosted-site-flow       +274 B  (+0.0%)     +121 B  (+0.0%)
import-flow                   +274 B  (+0.0%)     +121 B  (+0.0%)
entrepreneur-flow             -102 B  (-0.2%)      -61 B  (-0.7%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

...Object.fromEntries( queryParams ),
}
);
const redirectTo = `${ window.location.protocol }//${ window.location.host }/setup/entrepreneur/trialAcknowledge${ window.location.search }`;
Copy link
Contributor Author

@yansern yansern May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just the simplify the code here (and fix an existing bug where ?ref= is not inherited after redirection from signing-up.

Base automatically changed from add/entrepreneur-trial-page to trunk May 27, 2024 09:13
@yansern yansern force-pushed the add/store-last-step-during-trial-acknowledgement branch from 452f099 to 2017779 Compare May 27, 2024 09:27
@yansern yansern merged commit 7c42c68 into trunk May 27, 2024
11 checks passed
@yansern yansern deleted the add/store-last-step-during-trial-acknowledgement branch May 27, 2024 09:37
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants