Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy content via public-api, even when we're on a simple site. #91412

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

devicenull
Copy link
Contributor

@devicenull devicenull commented Jun 3, 2024

This reapplies the change from #90895 - there have been some changes to public-api.wordpress.com that resolved the problem that caused that MR to get reverted (D150124-wpcom). This change ultimately causes all links in the media library to be proxied via public-api.wordpress.com, which ensures that they are accessible even in the case of broken primary domains.

This reapplies the change from #90895 - there have been some changes to public-api.wordpress.com
that resolved the problem that caused that MR to get reverted (D150124-wpcom).  This change ultimately
causes all links in the media library to be proxied via public-api.wordpress.com, which ensures that
they are accessible even in the case of broken primary domains.
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~148 bytes removed 📉 [gzipped])

name                 parsed_size           gzip_size
entry-subscriptions       -533 B  (-0.0%)      -74 B  (-0.0%)
entry-stepper             -353 B  (-0.0%)      -77 B  (-0.0%)
entry-main                -353 B  (-0.0%)      -77 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~2097 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
settings-security                     +311 B  (+0.1%)      +52 B  (+0.0%)
settings-performance                  +311 B  (+0.1%)      +61 B  (+0.0%)
settings-jetpack                      +311 B  (+0.1%)      +75 B  (+0.0%)
write-flow                            +298 B  (+0.0%)      +93 B  (+0.0%)
woocommerce-installation              +298 B  (+0.1%)      +88 B  (+0.1%)
videopress-flow                       +298 B  (+0.0%)      +93 B  (+0.0%)
themes                                +298 B  (+0.0%)      +83 B  (+0.0%)
subscribers                           +298 B  (+0.0%)      +83 B  (+0.0%)
stats                                 +298 B  (+0.0%)      +88 B  (+0.0%)
staging-site                          +298 B  (+0.0%)      +83 B  (+0.0%)
site-purchases                        +298 B  (+0.0%)      +85 B  (+0.0%)
site-monitoring                       +298 B  (+0.0%)      +62 B  (+0.0%)
site-logs                             +298 B  (+0.0%)      +62 B  (+0.0%)
settings-writing                      +298 B  (+0.0%)      +71 B  (+0.0%)
settings-reading                      +298 B  (+0.1%)      +88 B  (+0.1%)
settings-podcast                      +298 B  (+0.1%)      +80 B  (+0.0%)
settings-newsletter                   +298 B  (+0.1%)      +77 B  (+0.0%)
settings-discussion                   +298 B  (+0.1%)      +88 B  (+0.1%)
settings                              +298 B  (+0.0%)      +80 B  (+0.0%)
scan                                  +298 B  (+0.0%)      +69 B  (+0.0%)
reader                                +298 B  (+0.0%)      +70 B  (+0.0%)
posts-custom                          +298 B  (+0.0%)      +41 B  (+0.0%)
posts                                 +298 B  (+0.0%)      +41 B  (+0.0%)
plugins                               +298 B  (+0.0%)      +83 B  (+0.0%)
plans                                 +298 B  (+0.0%)      +78 B  (+0.0%)
people                                +298 B  (+0.0%)      +59 B  (+0.0%)
pages                                 +298 B  (+0.1%)      +39 B  (+0.0%)
marketing                             +298 B  (+0.0%)      +88 B  (+0.0%)
jetpack-social                        +298 B  (+0.1%)      +90 B  (+0.1%)
jetpack-search                        +298 B  (+0.0%)      +69 B  (+0.0%)
jetpack-cloud-settings                +298 B  (+0.0%)      +88 B  (+0.0%)
jetpack-cloud-plugin-management       +298 B  (+0.0%)      +83 B  (+0.0%)
jetpack-cloud-agency-sites-v2         +298 B  (+0.0%)      +69 B  (+0.0%)
import                                +298 B  (+0.1%)      +88 B  (+0.1%)
hosting                               +298 B  (+0.0%)      +83 B  (+0.0%)
home                                  +298 B  (+0.0%)      +88 B  (+0.0%)
google-my-business                    +298 B  (+0.1%)      +79 B  (+0.0%)
github-deployments                    +298 B  (+0.0%)      +80 B  (+0.0%)
export                                +298 B  (+0.1%)      +88 B  (+0.1%)
email                                 +298 B  (+0.0%)      +88 B  (+0.0%)
earn                                  +298 B  (+0.0%)      +87 B  (+0.0%)
domains                               +298 B  (+0.0%)      +88 B  (+0.0%)
comments                              +298 B  (+0.0%)      +62 B  (+0.0%)
checkout                              +298 B  (+0.0%)      +89 B  (+0.0%)
build-flow                            +298 B  (+0.0%)      +93 B  (+0.0%)
backup                                +298 B  (+0.0%)      +69 B  (+0.0%)
add-ons                               +298 B  (+0.1%)      +88 B  (+0.1%)
activity                              +298 B  (+0.0%)      +77 B  (+0.0%)
a8c-for-agencies-sites                +298 B  (+0.0%)      +69 B  (+0.0%)
site-blocks                           +270 B  (+0.0%)      +91 B  (+0.0%)
security                              +270 B  (+0.0%)      +91 B  (+0.0%)
purchases                             +270 B  (+0.0%)      +91 B  (+0.0%)
privacy                               +270 B  (+0.0%)      +91 B  (+0.0%)
notification-settings                 +270 B  (+0.0%)      +91 B  (+0.0%)
media                                 +270 B  (+0.0%)      +78 B  (+0.0%)
me                                    +270 B  (+0.0%)      +91 B  (+0.0%)
link-in-bio-tld-flow                  +270 B  (+0.0%)      +91 B  (+0.0%)
help                                  +270 B  (+0.0%)      +91 B  (+0.0%)
developer                             +270 B  (+0.0%)      +91 B  (+0.0%)
account-close                         +270 B  (+0.0%)      +91 B  (+0.0%)
account                               +270 B  (+0.0%)      +91 B  (+0.0%)
newsletter-post-setup-flow             -28 B  (-0.0%)       -2 B  (-0.0%)
link-in-bio-post-setup-flow            -28 B  (-0.0%)       -2 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~435 bytes added 📈 [gzipped])

name                                                 parsed_size           gzip_size
async-load-store-app-store-stats                          +298 B  (+0.1%)      +88 B  (+0.1%)
async-load-design-playground                              +298 B  (+0.0%)      +87 B  (+0.0%)
async-load-design                                         +298 B  (+0.0%)      +87 B  (+0.0%)
async-load-calypso-my-sites-checkout-modal                +298 B  (+0.0%)      +89 B  (+0.0%)
async-load-calypso-components-web-preview-component       +298 B  (+0.1%)      +93 B  (+0.1%)
async-load-calypso-blocks-editor-checkout-modal           +298 B  (+0.0%)      +89 B  (+0.0%)
async-load-calypso-post-editor-editor-media-modal         +270 B  (+0.0%)      +78 B  (+0.0%)
async-load-signup-steps-p2-complete-profile                -28 B  (-0.0%)       -2 B  (-0.0%)
async-load-design-blocks                                   -28 B  (-0.0%)       -2 B  (-0.0%)
async-load-calypso-post-editor-media-modal                 -28 B  (-0.0%)       -2 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • command-palette-wp-admin
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix-files-on-simple-sites-2 on your sandbox.

@devicenull devicenull merged commit ce24991 into trunk Jun 4, 2024
13 checks passed
@devicenull devicenull deleted the fix-files-on-simple-sites-2 branch June 4, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants