Help Center: link to support docs if disconnected from JPOP #91630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
matticbot
added
the
[Status] Needs Review
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
|
Tested and everything is looking good! |
heavyweight
approved these changes
Jun 11, 2024
github-actions
bot
removed
the
[Status] Needs Review
alshakero
reviewed
Jun 11, 2024
Comment on lines
+289
to
+292
| public function is_jetpack_connected() { | ||
| $user_id = get_current_user_id(); | ||
| return ( new Connection_Manager( 'jetpack' ) )->is_user_connected( $user_id ); | ||
| } |
There was a problem hiding this comment.
This check should be only done in Atomic site.
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91558
Proposed Changes
Add check to Help Center in ETK to determine if user is connected to Jetpack. Then load simplified version if not.
Why are these changes being made?
Help Center relies on a WordPress.com user to do most of its functions. For Atomic and Jetpack only users this means they need to be connected to WordPress.com in order for it to work. To prevent loading a useless Help Center and save on loading times we have decided it would be best to make Help Center a button that opens the support docs if the user is not connected.
Testing Instructions
/wp-adminand the post editor to make sure the help center is functioning as normal./_cliand runningjetpack disconnect user ##USER_ID## --force. Be aware that this will remove your SSH key connection to the site if you have it setup./wp-adminand the post editor to see the Help Center open a new tab to the support docs.