-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A4A > Referrals: Implement client auth #91640
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~576 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~40 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it and can confirm the changes work as expected based on the test instructions. I left a few comments, but they are not blockers. 🚢
ac029ed
to
15c42c9
Compare
Closes https://github.com/Automattic/jetpack-genesis/issues/374
Proposed Changes
This PR
NOTE:
This is the client auth implementation. Currently, the agency users can see the client UI for testing purposes. We will disable it once everything is implemented. While this is not the ideal way to implement this. We decided to go ahead with this for the MVP (CC @vitozev)
Testing Instructions
isClient
to false here: https://github.com/Automattic/wp-calypso/pull/91640/files#diff-90a95b186e56a1d11455fff699d8237d3fa7bb6da1d8eba9583518ead6be10b5R32/client/subscriptions
& verify you are redirected to /overview.isClient
to true > Visit/client/subscriptions
Your Subscriptions
andPayment Methods
.Ideally, you will be directed to /overview if you have an agency account.Pre-merge Checklist