Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mailchimp feature as a marketing tool #91641

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from

Conversation

renatho
Copy link
Contributor

@renatho renatho commented Jun 10, 2024

Related to #91603

Proposed Changes

  • It adds Mailchimp feature as a WPCOM marketing tool.

Testing Instructions

  • In the left menu, navigate to Tools > Marketing.
  • Check that you see the new Mailchimp feature.
Screenshot 2024-06-11 at 16 34 15

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@renatho renatho self-assigned this Jun 10, 2024
@matticbot
Copy link
Contributor

matticbot commented Jun 10, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~127 bytes added 📈 [gzipped])

name       parsed_size           gzip_size
marketing       +575 B  (+0.1%)     +127 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@renatho renatho requested a review from donnapep June 10, 2024 15:06
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 10, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/mailchimp-feature-as-marketing-tool on your sandbox.

@renatho renatho marked this pull request as ready for review June 11, 2024 17:45
Copy link
Contributor

@donnapep donnapep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's wait for confirmation before merging.

@donnapep
Copy link
Contributor

@renatho Question...do we already have translations for these strings?

@renatho renatho added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Jun 11, 2024
@renatho
Copy link
Contributor Author

renatho commented Jun 11, 2024

do we already have translations for these strings?

Nops! As we talked, I'm adding the String Freeze label! Thank you, Donna!

@a8ci18n
Copy link

a8ci18n commented Jun 11, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/14492606

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @renatho for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Jun 16, 2024

Translation for this Pull Request has now been finished.

@donnapep donnapep linked an issue Jul 10, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Mailchimp card to Tools > Marketing
4 participants