-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A4A: fix referral wording #91959
A4A: fix referral wording #91959
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~1 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
@andrii-lysenko I hate doing this, but can we force a line break after the word "the" so we avoid a typographical runt? (a single word on a line by itself). Then we're good to go! |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/14953983 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @andrii-lysenko for including a screenshot in the description! This is really helpful for our translators. |
<br /> | ||
{ translate( 'total payments volume.' ) } | ||
</> | ||
) : ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there 👋 . Just wanted to share some i18n feedback about this string. Normally, we want to avoid splitting sentences because it's hard for translators to know if the strings go together. We would recommend putting the
as an inline tag instead of a separate entity that splits up the sentence. Something like:
{ translate( <> Receive a revenue share of 5 basis points on the <br /> total payments volume. </> ) }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Fixed it here: #92163
Translation for this Pull Request has now been finished. |
Related to p1718830020506339/1718741158.723619-slack-C06JY8QL0TU
Proposed Changes
Update wording as per request
Why are these changes being made?
Testing Instructions
/referrals/dashboard
and check wordingPre-merge Checklist