Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A: fix referral wording #91959

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Conversation

andrii-lysenko
Copy link
Contributor

Related to p1718830020506339/1718741158.723619-slack-C06JY8QL0TU

Proposed Changes

Update wording as per request

Screenshot 2024-06-19 at 2 08 44 PM

Why are these changes being made?

Testing Instructions

  • Using account with no referrals yet navigate to /referrals/dashboard and check wording

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@andrii-lysenko andrii-lysenko added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. A4A labels Jun 19, 2024
@andrii-lysenko andrii-lysenko requested review from jeffgolenski and a team June 19, 2024 21:10
@andrii-lysenko andrii-lysenko self-assigned this Jun 19, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug a4a/update-wording-in-referrals on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Jun 19, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1 bytes added 📈 [gzipped])

name                        parsed_size           gzip_size
a8c-for-agencies-referrals        +86 B  (+0.0%)       +1 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@jeffgolenski
Copy link
Member

@andrii-lysenko I hate doing this, but can we force a line break after the word "the" so we avoid a typographical runt? (a single word on a line by itself). Then we're good to go!

CleanShot 2024-06-19 at 17 22 56

@andrii-lysenko andrii-lysenko merged commit 59ba085 into trunk Jun 19, 2024
11 checks passed
@andrii-lysenko andrii-lysenko deleted the a4a/update-wording-in-referrals branch June 19, 2024 21:57
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 19, 2024
@a8ci18n
Copy link

a8ci18n commented Jun 19, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/14953983

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @andrii-lysenko for including a screenshot in the description! This is really helpful for our translators.

<br />
{ translate( 'total payments volume.' ) }
</>
) : (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there 👋 . Just wanted to share some i18n feedback about this string. Normally, we want to avoid splitting sentences because it's hard for translators to know if the strings go together. We would recommend putting the
as an inline tag instead of a separate entity that splits up the sentence. Something like:

{ translate( <> Receive a revenue share of 5 basis points on the <br /> total payments volume. </> ) }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed it here: #92163

@a8ci18n
Copy link

a8ci18n commented Jun 23, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants