Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A-Partner Directory: Add to step 3 a publish CTA button #92035

Merged
merged 20 commits into from
Jun 27, 2024

Conversation

cleacos
Copy link
Contributor

@cleacos cleacos commented Jun 21, 2024

Resolves: https://github.com/Automattic/automattic-for-agencies-dev/issues/699
Resolves: https://github.com/Automattic/automattic-for-agencies-dev/issues/701

Proposed Changes

This PR adds the step-3 Publish button:

image

  • Extract and apply some validation code (URLs) as tools
  • Allow to save the agency details at any time, without the required fields.
  • Shows step 1 when it's the first time the agency is applying.
  • Add the Publish button in step 3. Once the agency completes the steps 1 and 2, they can publish the application.

Why are these changes being made?

Testing Instructions

  • Apply for a few directories
  • Get approved from at least one of them. Use the MC tool for approve it: /agencies/partner-directory.php?mca4a_agency_id={your_agency_id}
  • You can restore your application using the endpoint directly: PUT https://public-api.wordpress.com/wpcom/v2/agency/{your_agency_id}/profile/application

Dummy data:

{
    "products": [
        "woocommerce",
        "jetpack"
    ],
	  "services": ["content_strategy_development"],
    "directories": [
        {
					"directory": "wordpress",
					"urls": [
						"https:\/\/example11.com",
						"https:\/\/example2.com",
						"https:\/\/example3.com",
						"https:\/\/example4.com",
						"https:\/\/example5.com"
					],
					"note": "My WordPress.com application",
					"is_published": false,
					"status": "pending"
        },
        {
					"directory": "jetpack",
					"urls": [
						"https:\/\/example1.com",
						"https:\/\/example2.com",
						"https:\/\/example3.com",
						"https:\/\/example4.com",
						"https:\/\/example55.com"
					],
					"note": "My Jetpack.com application",
					"is_published": false,
					"status": "pending"
				}
    ],
    "status": "in-progress",
    "feedback_url": "https://example3.com",
		"is_published": false
}

  • Edit agency expertise
  • Edit agency profile
  • Click on the Publish button:
  • You will see:

image

and the summary Congratulation page:

image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@cleacos cleacos self-assigned this Jun 21, 2024
@matticbot
Copy link
Contributor

matticbot commented Jun 21, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~308 bytes added 📈 [gzipped])

name                                parsed_size           gzip_size
a8c-for-agencies-partner-directory       +951 B  (+0.2%)     +308 B  (+0.2%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@cleacos cleacos force-pushed the add/a4a/partner-directory-add-step-3-publish-cta branch from d51c65d to 001c02f Compare June 27, 2024 12:14
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/a4a/partner-directory-add-step-3-publish-cta on your sandbox.

@cleacos cleacos requested a review from a team June 27, 2024 13:18
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 27, 2024
@cleacos cleacos marked this pull request as ready for review June 27, 2024 13:18
@cleacos cleacos requested a review from vitozev June 27, 2024 13:28
Copy link
Contributor

@vitozev vitozev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected and the code changes makes sense to me 👍

formData.logoUrl.length > 0 &&
validateURL( formData.logoUrl ) &&
// landingPageUrl is optional
( formData.landingPageUrl.length === 0 || validateURL( formData.landingPageUrl ) ) &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: In this case I think you will be able to enter $ as a value for instance and validation will pass.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. The validations will be updated in this PR: #92123

@cleacos cleacos force-pushed the add/a4a/partner-directory-add-step-3-publish-cta branch from 4bd1611 to 3617eab Compare June 27, 2024 14:42
@cleacos cleacos merged commit 31012ed into trunk Jun 27, 2024
11 checks passed
@cleacos cleacos deleted the add/a4a/partner-directory-add-step-3-publish-cta branch June 27, 2024 14:56
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 27, 2024
@a8ci18n
Copy link

a8ci18n commented Jun 27, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/15476154

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @cleacos for including a screenshot in the description! This is really helpful for our translators.

arcangelini pushed a commit that referenced this pull request Jun 28, 2024
* Add Publish CTA button

* Add track event on PublishProfileClick

* Change the Finish Profile by Edit Profile if the profile is completed

* Move utils to a common file.

* Use validateURL from tools

* Don't validate profile form on update it.

* Update style class name

* Add the is_published field to the application request

* Update URL validation

* Add application param to the submit method

* Handle the is_published => isPublished

* Add the is_published field to partner_directory_application

* Add AgencyDirectoryApplication.isPublished param

* Update Dashboard to submit the profile published

* Remove the unused published field in partner_directory_application

* Fix wrong field name: published => isPublished

* Remove page from dependency. Not necessary.

* Update the Dashboard to set the application as published + notice on success.

* Add a key to the StepSectionItem map

* Fix: Refresh the setApplicationData when agency is updated
@a8ci18n
Copy link

a8ci18n commented Jun 30, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants