-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A4A-Partner Directory: Add to step 3 a publish CTA button #92035
A4A-Partner Directory: Add to step 3 a publish CTA button #92035
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~308 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
d51c65d
to
001c02f
Compare
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as expected and the code changes makes sense to me 👍
formData.logoUrl.length > 0 && | ||
validateURL( formData.logoUrl ) && | ||
// landingPageUrl is optional | ||
( formData.landingPageUrl.length === 0 || validateURL( formData.landingPageUrl ) ) && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: In this case I think you will be able to enter $
as a value for instance and validation will pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. The validations will be updated in this PR: #92123
4bd1611
to
3617eab
Compare
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/15476154 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @cleacos for including a screenshot in the description! This is really helpful for our translators. |
* Add Publish CTA button * Add track event on PublishProfileClick * Change the Finish Profile by Edit Profile if the profile is completed * Move utils to a common file. * Use validateURL from tools * Don't validate profile form on update it. * Update style class name * Add the is_published field to the application request * Update URL validation * Add application param to the submit method * Handle the is_published => isPublished * Add the is_published field to partner_directory_application * Add AgencyDirectoryApplication.isPublished param * Update Dashboard to submit the profile published * Remove the unused published field in partner_directory_application * Fix wrong field name: published => isPublished * Remove page from dependency. Not necessary. * Update the Dashboard to set the application as published + notice on success. * Add a key to the StepSectionItem map * Fix: Refresh the setApplicationData when agency is updated
Translation for this Pull Request has now been finished. |
Resolves: https://github.com/Automattic/automattic-for-agencies-dev/issues/699
Resolves: https://github.com/Automattic/automattic-for-agencies-dev/issues/701
Proposed Changes
This PR adds the step-3 Publish button:
Why are these changes being made?
Testing Instructions
/agencies/partner-directory.php?mca4a_agency_id={your_agency_id}
PUT https://public-api.wordpress.com/wpcom/v2/agency/{your_agency_id}/profile/application
Dummy data:
and the summary Congratulation page:
Pre-merge Checklist