Stats: Show upgrade notices for commercial sites with PWYW plans

[a8ck3n]

Related to #81361.

Proposed Changes

Show the commercial upgrade notice on any site flagged as isCommercial that has a PWYW plan. Previously we didn't show the notice to these sites.

Why are these changes being made?

The PWYW plans are meant for non-commercial sites. It's possible to purchase one if the site has not been classified or if the site's classification changes over time. We want to make sure we surface notices to upgrade to the correct license if we find a mismatch of classification & license type.

Testing Instructions

• Add a PWYW plan to your test site.
• Force the site to commercial status using the "jetpack-site-is-commercial-override" override on the Blog RC tool.
• Visit the Stats page and confirm the notice is visible.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-112011

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-112011&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-112011&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• odyssey-stats
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/stats-notices-for-commercial-pwyw on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~113 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
stats       +310 B  (+0.0%)     +113 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[kangzj]

It works well for self hosted, Atomic and simple sites. Minor suggestions inlined, no blockers.

[kangzj]

I understand this might be written intentionally in two conditions but for the sake of simplicity, could we merge them to one?

[kangzj]

Can we please not change the pattern here just to be consistent?

Not related to the PR: I'm thinking maybe we could put those notices back to their own files, where the notice component are defined. It'll be better to satisfy the open/close principal. Thought?

[kangzj]

Side note: We currently only have two features for Stats, stats-paid and stats-free, and we probably want to introduce another one stats-commercial which includes support for all advanced features and commercial use.