Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] #6

Closed
Delfite opened this issue Oct 3, 2021 · 2 comments
Closed

[Bug Report] #6

Delfite opened this issue Oct 3, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@Delfite
Copy link

Delfite commented Oct 3, 2021

Describe the bug
In the most recent update to the mod, the recipe for Netherite-Iron ingots now requires Netherite-Iron ingots to make. How in the fu-

To Reproduce
Steps to reproduce the behavior:

  1. Open JEI
  2. View the recipe for Netherite-Iron Ingots

Expected behavior
It shouldn't require a Netherite-Iron ingot to make a Netherite-Iron ingot.

Screenshots
2021-10-03_03 19 39

Technical Information (please complete the following information):

  • Minecraft-version: 1.17.1
  • Forge-version: 37.0.75
  • Mod-version: advancednetherite-1.8.0-1.17.1.jar

Also, here's some Grammar corrections for you to include in the next update because poor grammar makes people like me wanna lose our minds:

Change the "Pacifies Endermans" text to "Pacifies Endermen"
The text for everything involving a "/" in it needs to be swapped for a "-" because a slash is supposed to be used as a substitute for "or", not to unify two things into one thing. These aren't "Netherite or Iron ingots" they're "Netherite-Iron ingots" since you're unifying two materials together, same goes for every other item including tools and armor.

@Delfite Delfite added the bug Something isn't working label Oct 3, 2021
@Autovw Autovw closed this as completed in 994afac Oct 3, 2021
Autovw added a commit that referenced this issue Oct 3, 2021
Thanks #6 for pointing out, should've known this 🙃
Autovw added a commit that referenced this issue Oct 3, 2021
Thanks #6 for pointing out, makes more sense to use dashes rather than slashes after having thought about it.
Autovw added a commit that referenced this issue Oct 3, 2021
Backports changes from 1.17.X branch, reference: #6
@Autovw
Copy link
Owner

Autovw commented Oct 3, 2021

Might be a good idea to start using data generators to prevent this from happening in the future.
Thank you for reporting this issue!

After having thought about it I have decided to use dashes instead of slashes, makes more sense indeed.
Thanks for the feedback, everything should be fixed in version 1.8.1.

@Delfite
Copy link
Author

Delfite commented Oct 3, 2021

Thanks a bunch, glad you responded to this so quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants