Skip to content

Commit ab53c25

Browse files
will-dzchrisli30
authored andcommitted
fix: improve variable naming to avoid shadowing and enhance clarity
- Use epochJob instead of job for epoch-based scheduling to avoid variable shadowing - Use cronJob instead of job for cron-based scheduling for consistency - Addresses Copilot suggestions about variable scope and naming clarity
1 parent f686629 commit ab53c25

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

core/taskengine/trigger/time.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ func (t *TimeTrigger) AddCheck(check *avsproto.SyncMessagesResp_TaskMetadata) er
181181
}
182182

183183
cronExpr := t.epochToCron(epoch)
184-
job, err := t.scheduler.NewJob(
184+
epochJob, err := t.scheduler.NewJob(
185185
gocron.CronJob(cronExpr, false),
186186
gocron.NewTask(triggerFunc),
187187
// In FixedTime, we want to run the job only once
@@ -190,7 +190,7 @@ func (t *TimeTrigger) AddCheck(check *avsproto.SyncMessagesResp_TaskMetadata) er
190190
if err != nil {
191191
return fmt.Errorf("failed to schedule epoch job: %w", err)
192192
}
193-
jobs = append(jobs, job)
193+
jobs = append(jobs, epochJob)
194194
}
195195
} else if cronTrigger := check.GetTrigger().GetCron(); cronTrigger != nil {
196196
// Handle cron-based scheduling
@@ -214,15 +214,15 @@ func (t *TimeTrigger) AddCheck(check *avsproto.SyncMessagesResp_TaskMetadata) er
214214
}
215215

216216
// Schedule with calculated start time to prevent immediate execution
217-
job, err := t.scheduler.NewJob(
217+
cronJob, err := t.scheduler.NewJob(
218218
gocron.CronJob(cronExpr, false),
219219
gocron.NewTask(triggerFunc),
220220
gocron.WithStartAt(gocron.WithStartDateTime(nextExecTime)),
221221
)
222222
if err != nil {
223223
return fmt.Errorf("failed to schedule cron job: %w", err)
224224
}
225-
jobs = append(jobs, job)
225+
jobs = append(jobs, cronJob)
226226
}
227227
}
228228

0 commit comments

Comments
 (0)