Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Styling column section to the Table page #979

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

Satoshi-Sh
Copy link
Contributor

@Satoshi-Sh Satoshi-Sh commented Jun 4, 2024

Related Issue

Fixed #965

Updates

  • Add two new images
  • Created Styling column section

Another Issue

I found another issue in the example of the table page. The declaration should be large_x_range
Let me know if you want me to fix this in this PR.

x_range = [round(20*i/1000-10, 2) for i in range(0, 1001)]

data = {
    "x": large_x_range,
    # y1 = x*x
    "y1": [round(x*x, 5) for x in large_x_range],
    # y2 = 100-x*x
    "y2": [round(100-x*x, 5) for x in large_x_range]
}```

@FlorianJacta
Copy link
Member

Sure, you can fix it here. It would be simpler

@FlorianJacta
Copy link
Member

In fact, the issue is not so simple in the docs. This is not that td has to be erased but td shouldn't be present when styling columns.

style[column_name]

See this issue that we want to solve through documentation: Avaiga/taipy#1279

Sorry my issue was poorly explained

@FlorianJacta FlorianJacta self-requested a review June 4, 2024 13:49
@FlorianJacta FlorianJacta added 📈 Improvement Improvement of a feature. 🖰 GUI Related to GUI 📄 Documentation Internal or public documentation labels Jun 4, 2024
@Satoshi-Sh
Copy link
Contributor Author

Then, should I keep the styling rows section as is and create a styling column section with the example of gorkemalgan's codes?

@FlorianJacta
Copy link
Member

FlorianJacta commented Jun 4, 2024

That could be a good idea to separate it, yes

@Satoshi-Sh Satoshi-Sh changed the title Remove tds from css in the Table Page example Add Styling column section to the Table page Jun 4, 2024
Copy link
Member

@FlorianJacta FlorianJacta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This will help the users a lot.

It is possible that this PR is blocked by another one so it won't be merged soon.

docs/manuals/gui/viselements/table.md_template Outdated Show resolved Hide resolved
docs/manuals/gui/viselements/table.md_template Outdated Show resolved Hide resolved
docs/manuals/gui/viselements/table.md_template Outdated Show resolved Hide resolved
docs/manuals/gui/viselements/table.md_template Outdated Show resolved Hide resolved
Copy link
Member

@FlorianJacta FlorianJacta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work! I mark it blocked by #940

We will merge it as soon as possible.

@FlorianJacta FlorianJacta added the ❌ Blocked Issue is blocked label Jun 5, 2024
@jrobinAV jrobinAV removed the ❌ Blocked Issue is blocked label Jul 22, 2024
@jrobinAV
Copy link
Member

The pr #940 is merged. This issue is not blocked anymore.

Copy link
Member

@jrobinAV jrobinAV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of a restructuring of the documentation, the PR has some conflicts.

Here are the new paths:

  • docs/manuals/userman/gui/viselements/generic/table-columnstyle-d.png
  • docs/manuals/userman/gui/viselements/generic/table-columnstyle-l.png
  • docs/manuals/userman/gui/viselements/generic/table.md_template

Thank you.

@FabienLelaquais
Copy link
Member

Hey @Satoshi-Sh
Indeed as @jrobinAV mentioned, the directory for the three modified files (including the two new images) have changed from
docs/manuals/gui/viselements/
to
docs/manuals/userman/gui/viselements/generic/
Can you update your working environment then move these files, and let me know?
Thanks!!

@Satoshi-Sh
Copy link
Contributor Author

I rebased the branch. I think I did it right. Let me know if there's something wrong.

@FabienLelaquais FabienLelaquais merged commit d4b4bf2 into Avaiga:develop Jul 22, 2024
1 check passed
@FabienLelaquais
Copy link
Member

Thanks @Satoshi-Sh!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 Documentation Internal or public documentation 🖰 GUI Related to GUI 📈 Improvement Improvement of a feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG-Erase td in CSS in table styling doc
4 participants