-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Styling column section to the Table page #979
Add Styling column section to the Table page #979
Conversation
Sure, you can fix it here. It would be simpler |
In fact, the issue is not so simple in the docs. This is not that td has to be erased but td shouldn't be present when styling columns. style[column_name] See this issue that we want to solve through documentation: Avaiga/taipy#1279 Sorry my issue was poorly explained |
Then, should I keep the styling rows section as is and create a styling column section with the example of gorkemalgan's codes? |
d2b7587
to
a16fbe8
Compare
That could be a good idea to separate it, yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! This will help the users a lot.
It is possible that this PR is blocked by another one so it won't be merged soon.
a0f53be
to
7e32bfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work! I mark it blocked by #940
We will merge it as soon as possible.
The pr #940 is merged. This issue is not blocked anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of a restructuring of the documentation, the PR has some conflicts.
Here are the new paths:
- docs/manuals/userman/gui/viselements/generic/table-columnstyle-d.png
- docs/manuals/userman/gui/viselements/generic/table-columnstyle-l.png
- docs/manuals/userman/gui/viselements/generic/table.md_template
Thank you.
Hey @Satoshi-Sh |
7e32bfd
to
0565658
Compare
I rebased the branch. I think I did it right. Let me know if there's something wrong. |
Thanks @Satoshi-Sh!! |
Related Issue
Fixed #965
Updates
Another Issue
I found another issue in the example of the table page. The declaration should be large_x_range
Let me know if you want me to fix this in this PR.