fix(upload-core): auto retry failed uploads (#73)

Fixes #71

Author: robmcguinness

packages/upload-core/src/tests/upload.test.js

@@ -26,6 +26,13 @@ const optionsWithMeta = {
   clientId: 'c',
 };
 
+const optionsWithRetry = {
+  bucketId: 'a',
+  customerId: 'b',
+  clientId: 'c',
+  retryDelays: [1000, 2000],
+};
+
 describe('upload.core', () => {
   it('should be defined', () => {
     expect(Upload).toBeTruthy();
@@ -43,6 +50,13 @@ describe('upload.core', () => {
     }).toThrow('[options.bucketId] must be defined');
   });
 
+  it('should allow override to defaults', () => {
+    const file = Buffer.from('hello world'.split(''));
+    file.name = 'fileName.png';
+    const upload = new Upload(file, optionsWithRetry);
+    expect(upload.options.retryDelays[0]).toBe(optionsWithRetry.retryDelays[0]);
+  });
+
   it('should allow single file as constructor argument', () => {
     const file = Buffer.from('hello world'.split(''));
     file.name = 'fileName.png';

packages/upload-core/src/upload.js

@@ -15,6 +15,8 @@ const defaultOptions = {
   endpoint: '/ms/api/availity/internal/core/vault/upload/v1/resumable',
   chunkSize: 3e6, // 3MB
   removeFingerprintOnSuccess: true,
+  retryDelays: [0, 1000, 3000, 5000],
+  stripFileNamePathSegments: true,
   fingerprint(file, options = {}) {
     const attributes = [file.name, file.type, file.size, file.lastModified];
     let attributesKey = 'tus-';
@@ -58,7 +60,7 @@ class Upload {
     }
 
     this.file = file;
-    this.options = Object.assign(options, defaultOptions);
+    this.options = Object.assign({}, defaultOptions, options);
     this.percentage = 0;
     this.onError = [];
     this.onSuccess = [];
@@ -182,6 +184,7 @@ class Upload {
       resume: true,
       endpoint: `${this.options.endpoint}/${this.options.bucketId}/`,
       chunkSize: this.options.chunkSize,
+      retryDelays: this.options.retryDelays,
       removeFingerprintOnSuccess: this.options.removeFingerprintOnSuccess,
       fingerprint: this.options.fingerprint,
       metadata,
@@ -292,7 +295,7 @@ class Upload {
   }
 
   trimFileName(fileName) {
-    if (this.options.stripFileNamePathSegments !== false) {
+    if (this.options.stripFileNamePathSegments) {
       fileName = fileName.substring(fileName.lastIndexOf('\\') + 1);
       fileName = fileName.substring(fileName.lastIndexOf('/') + 1);
     }