Feat/text column formatting #283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review! |
giard-alexandre
force-pushed
the
feat/text-column-formatting
branch
from
24486c5
to
47a7c17
Compare
giard-alexandre
force-pushed
the
feat/text-column-formatting
branch
from
47a7c17
to
3d95836
Compare
grokys
reviewed
Oct 31, 2024
There was a problem hiding this comment.
Hi @giard-alexandre ,
Thanks for this. I've taken a look and can see a problem when the text column is editable. For example, if I change the GDP column in the "Countries" sample to be editable, then I get a FormatException when editing the value in the UI
|
Fixed by #283 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #278
Adds the property
StringFormattoTextColumnOptions. This new option allows us to specify a custom string format for each cell, without needing to useTemplateColumns.