Fix OnOpenGlInit getting called twice #12713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
|
You can test this PR using the following package version. |
kekekeks
approved these changes
Aug 29, 2023
grokys
added
the
backport-candidate-11.0.x
grokys
pushed a commit
that referenced
this pull request
Oct 2, 2023
Fix OnOpenGlInit getting called twice
grokys
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This fixes #10371 it removes the call to
OnOpenGlInitin the methodEnsureInitializedCoreso now it only gets called at the end ofInitializeAsync.What is the current behavior?
Currently
InitializeAsynccallsEnsureInitializedCore, which callsOnOpenGlInitat the end and returns true after thatInitializeAsynccallsOnOpenGlInitaswell.What is the updated/expected behavior with this PR?
Now if u create a Control inheriting from
OpenGlControlBasethe methodOnOpenGlInitwill only be called once per initialization.How was the solution implemented (if it's not obvious)?
Removed the call to
OnOpenGlInitinEnsureInitializedCore.Fixed issues
Fixes #10371