Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Tmds.DBus.SourceGenerator 0.0.10 #12730

Merged
merged 6 commits into from
Aug 31, 2023

Conversation

affederaffe
Copy link
Contributor

What does the pull request do?

Bump Tmds.DBus.SourceGenerator to 0.0.10 which:

  1. Implements org.freedesktop.DBus.Introspectable which is needed by the python dbus implementation for type parsing...
  2. Introduces an optimization for variant byte[]. Instead of creating a DBusByteArrayItem with DBusByteItems, use DBusByteArrayItem instead.

Also report the version of the com.canonical.dbusmenu as 4, as required by vala-panel

What is the current behavior?

The global menu only works one KDE(?) as it doesn't seem to rely on introspection.

What is the updated/expected behavior with this PR?

The global menu should work with all implementations.

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

#10767

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0038970-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@jmacato jmacato added this pull request to the merge queue Aug 31, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 31, 2023
@jmacato jmacato enabled auto-merge August 31, 2023 06:43
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0038990-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0039029-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@jmacato jmacato added this pull request to the merge queue Aug 31, 2023
Merged via the queue into AvaloniaUI:master with commit fa72057 Aug 31, 2023
5 checks passed
@maxkatz6 maxkatz6 added the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label Dec 5, 2023
maxkatz6 pushed a commit that referenced this pull request Dec 5, 2023
@maxkatz6 maxkatz6 added backported-11.0.x and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants