Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VirtualizingPanel's RemoveInternalChildRange() removing elements … #12877

Conversation

liwuqingxin
Copy link
Contributor

…from 0 (#12476)

What does the pull request do?

Fix #12476.

What is the current behavior?

The RemoveInternalChildRange() of VirtualizingPanel always remove children from 0.

What is the updated/expected behavior with this PR?

It should remove children from the index that passed in.

Fixed issues

Fixes #12476.

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0039436-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

Copy link
Member

@grokys grokys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks for fixing that! 🤦

@grokys grokys added this pull request to the merge queue Sep 13, 2023
Merged via the queue into AvaloniaUI:master with commit df0342f Sep 13, 2023
5 checks passed
@maxkatz6 maxkatz6 added the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label Dec 7, 2023
@maxkatz6 maxkatz6 added backported-11.0.x and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VirtualizingPanel.RemoveInternalChildRange(int index, int count) remove elements from 0.
4 participants