Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FluentTheme: settable ListBoxItem.FontWeight/FontSize #12958

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

MrJul
Copy link
Member

@MrJul MrJul commented Sep 20, 2023

What does the pull request do?

This PR makes FontWeight and FontSize being settable for ListBoxItem using the fluent theme, so users can change these properties using simple styles.

What is the current behavior?

Currently FontWeight and FontSize are ignored in the fluent theme: the ContentPresenter from the ListBoxItem template has these properties set directly.

What is the updated/expected behavior with this PR?

ContentPresenter.FontSize/FontWeight are template bound to ListBoxItem.FontSize/FontWeight.

@MrJul MrJul added the area-fluent Fluent theme related label Sep 20, 2023
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0039710-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added this pull request to the merge queue Sep 20, 2023
Merged via the queue into AvaloniaUI:master with commit d43dde5 Sep 21, 2023
5 checks passed
@MrJul MrJul deleted the fix/fluent-listboxitem-fontsize branch September 21, 2023 10:30
@MrJul MrJul added the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label Sep 30, 2023
@grokys grokys added backported-11.0.x and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants