Fix DateTimePicker scroll down #13482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
approved these changes
Nov 3, 2023
maxkatz6
added
the
backport-candidate-11.0.x
maxkatz6
pushed a commit
that referenced
this pull request
Dec 5, 2023
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR fixes bug on down button in the Time/Date pickers.
What is the current behavior?
Currently if you press the down button in the AM/PM designator it will go blank.
If you scroll to the end of the year part in the DatePicker, the down button will stop selecting at some point.
The possible scroll height is calculated like in the standard scroll viewer, but in this case we can go beyond the viewport height in order to select the last items.
What is the updated/expected behavior with this PR?
Down button should select the next item up till the end.
How was the solution implemented (if it's not obvious)?
The scroll height should be extent heght minus item height. This will allow it to scroll up to the last item.
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues