DataGrid inertial scroll support (#13502) #13511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't there be a package created by the CI build that I can use to test this? |
It was "true" before we even had this property, so this PR fixes unintentional breaking change to previous behavior. Just to clarify it. |
|
@stogle looks like bot has died. But you still can find build number in the Azure CI - |
maxkatz6
added
the
backport-candidate-11.0.x
maxkatz6
pushed a commit
that referenced
this pull request
Dec 5, 2023
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Adds inertial scrolling support to DataGrid via a new IsScrollInertiaEnabled property, which is true by default. See #13502.
What is the current behavior?
DataGrid does not currently support inertial scrolling, meaning that when the user scrolls the grid with a touch gesture, scrolling always stops as soon as the gesture ends.
What is the updated/expected behavior with this PR?
With this PR, DataGrid supports inertial scrolling, and it is enabled by default, meaning that when the user scrolls the grid with a "flick" gesture, scrolling will decelerate rather than stop as soon as the gesture ends. The current behavior can be restored by setting the IsScrollInertiaEnabled property to false.
How was the solution implemented (if it's not obvious)?
As described in #13502, a property was added to DataGrid, and the Fluent and Simple templates were updated to use it.
Checklist
Breaking changes
As the new property defaults to true, DataGrid will now use inertial scrolling by default. IMO this is expected behavior (consistent with other controls that use ScrollViewer), not a breaking change.
Obsoletions / Deprecations
None.
Fixed issues
Fixes #13502