Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win32 file picker fixes #13625

Merged
merged 4 commits into from
Nov 16, 2023
Merged

Win32 file picker fixes #13625

merged 4 commits into from
Nov 16, 2023

Conversation

maxkatz6
Copy link
Member

@maxkatz6 maxkatz6 commented Nov 15, 2023

What does the pull request do?

Both WPF and Chrome use SIGDN_DESKTOPABSOLUTEPARSING instead of SIGDN_FILESYSPATH while retrieving display-name of the picker files. We should do the same.
Also this PR:

  • Add missing ConfigureAwait(false)
  • Includes FOS_PATHMUSTEXIST by default (it seems to be the default, but WPF still includes it...could it not default on some OS versions?)
  • Safely skip the file if GetDisplayName failed
  • Avoid System.Linq as it's not really necessary here, but adds multiple iterations over the same results array

Fixed issues

Fixes #13613
Fixes #13624
Fixes #8584
Fixes #7879

Copy link
Contributor

@Takoooooo Takoooooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Takoooooo Takoooooo added this pull request to the merge queue Nov 15, 2023
Merged via the queue into master with commit eb7b6fe Nov 16, 2023
7 checks passed
@Takoooooo Takoooooo deleted the some-win32-file-dialog-fixes branch November 16, 2023 00:10
@maxkatz6 maxkatz6 added the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label Nov 28, 2023
maxkatz6 added a commit that referenced this pull request Dec 5, 2023
* Use SIGDN_DESKTOPABSOLUTEPARSING instead of SIGDN_FILESYSPATH, and avoid crashing on GetDisplayName

* Don't forget fking .ConfigureAwait(false)

* Fix wrong method call

* Avoid System.Linq and double iterations over results array
@maxkatz6 maxkatz6 added backported-11.0.x and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants