Fix Some Virtualizing List Update Bugs #13795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't rely on a remove/insert - it creates more work than needed.
grokys
added
bug
backport-candidate-11.0.x
grokys
changed the title
|
You can test this PR using the following package version. |
|
This might be related to the issues with collection changes not reflecting properly in the displayed list that has been elusive for me to track down and understand. I see that in a real app but am unable to repro so far in a simple test cases (though I forgot to check insert). I'm going to re-run with this package and see if that fixes things. |
maxkatz6
approved these changes
Dec 2, 2023
maxkatz6
pushed a commit
that referenced
this pull request
Dec 5, 2023
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
grokys
added a commit
to AvaloniaUI/Avalonia.Controls.TreeDataGrid
that referenced
this pull request
Dec 7, 2023
Port fixes to `RealizedStackElements` from AvaloniaUI/Avalonia#13795.
grokys
added a commit
to AvaloniaUI/Avalonia.Controls.TreeDataGrid
that referenced
this pull request
Dec 10, 2023
Port fixes to `RealizedStackElements` from AvaloniaUI/Avalonia#13795.
nil4
pushed a commit
to royalapplications/Avalonia.Controls.TreeDataGrid
that referenced
this pull request
Dec 20, 2023
Port fixes to `RealizedStackElements` from AvaloniaUI/Avalonia#13795.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
RealizedStackElementswhen items are inserted or removed, and add tests for these casesReplaceis carried out, don't implement it using a remove and an insert. It's much simpler to just unrealize the element.Fixed issues
Fixes #11666 (and probably more, need to check)