Added default excludes for AvaloniaXaml #13809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Dec 3, 2023
maxkatz6
added
the
backport-candidate-11.0.x
maxkatz6
pushed a commit
that referenced
this pull request
Dec 5, 2023
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Adds the default excludes to the default include of Avalonia XAML files in the build targets.
What is the current behavior?
Avalonia XAML files included by default do not respect the default excludes, unlike all other files included by default in the .NET SDK.
What is the updated/expected behavior with this PR?
Avalonia XAML files included by default respect the default excludes.
How was the solution implemented (if it's not obvious)?
Copied the exclude behavior from the .NET SDK (reference):
Looking at a preprocessed msbuild xml file, this exclude appears in most (if not all) default item includes in the .NET SDK.
Checklist
Breaking changes
The default behavior of Avalonia build targets changed, but it is now aligned with the .NET SDK.
Fixed issues
Fixes #13723