Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsubscribe android back handler when toplevel is disposed #13831

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

emmauss
Copy link
Contributor

@emmauss emmauss commented Dec 5, 2023

What does the pull request do?

When the ToplevelImpl on android is disposed, unsubscribe from the activity's back requested event.

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

Fixes #13829

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0042658-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label Dec 5, 2023
@maxkatz6 maxkatz6 added this pull request to the merge queue Dec 6, 2023
Merged via the queue into master with commit a028347 Dec 6, 2023
7 checks passed
@maxkatz6 maxkatz6 deleted the android_back_handler_dispose branch December 6, 2023 06:58
@maxkatz6 maxkatz6 added backported-11.0.x and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Jan 17, 2024
maxkatz6 pushed a commit that referenced this pull request Jan 17, 2024
#Conflicts:
#	src/Android/Avalonia.Android/Platform/AndroidSystemNavigationManager.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AndroidSystemNavigationManagerImpl object not to be garbage collected
3 participants